Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43276

CoreWrapperStep should run SimpleBuildWrapper.setUp asynchronously

    Details

    • Similar Issues:
    • Released As:
      workflow-basic-steps 2.14

      Description

      CoreStep runs SimpleBuildStep.perform in a background thread, via SynchronousNonBlockingStepExecution, so while pending JENKINS-30383 there is a high chance that a Jenkins restart will cause a build failure, at least the CPS VM thread is not blocked. However CoreWrapperStep runs SimpleBuildWrapper.setUp directly from Execution.start, since there is no block-scoped equivalent of SynchronousNonBlockingStepExecution, which means that a slow wrapper could block the VM thread indefinitely.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            JENKINS-26055 (or JENKINS-37011) would make it easier to write a regular Step which as part of its functionality launches an external process with an unknown run duration.

            Show
            jglick Jesse Glick added a comment - JENKINS-26055 (or  JENKINS-37011 ) would make it easier to write a regular  Step which as part of its functionality launches an external process with an unknown run duration.
            Hide
            jglick Jesse Glick added a comment -

            See JENKINS-26056 for an example Sam Van Oort.

            Show
            jglick Jesse Glick added a comment - See  JENKINS-26056 for an example Sam Van Oort .
            Hide
            jglick Jesse Glick added a comment -

            Defining the necessary API in JENKINS-49337.

            Show
            jglick Jesse Glick added a comment - Defining the necessary API in JENKINS-49337 .
            Hide
            dnusbaum Devin Nusbaum added a comment -

            The fix for this issue was just released in version 2.14 of Pipeline Basic Steps Plugin.

            Show
            dnusbaum Devin Nusbaum added a comment - The fix for this issue was just released in version 2.14 of Pipeline Basic Steps Plugin.

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: