Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43400

Autofavorite broken on remote agents

    XMLWordPrintable

    Details

    • Epic Link:
    • Sprint:
      Blue Ocean - 1.1-beta-1, Blue Ocean - 1.1-beta2, Blue Ocean 1.1-beta4, Blue Ocean 1.1
    • Similar Issues:

      Description

      Observable in jenkinsci/workflow-demo:2017-04-05:

      ... io.jenkins.blueocean.autofavorite.FavoritingScmListener onCheckout
      SEVERE: Unexpected error when retrieving changeset
      hudson.plugins.git.GitException: Error launching git whatchanged
      	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$6.execute(CliGitAPIImpl.java:854)
      	at io.jenkins.blueocean.autofavorite.FavoritingScmListener.getChangeSet(FavoritingScmListener.java:137)
      	at io.jenkins.blueocean.autofavorite.FavoritingScmListener.onCheckout(FavoritingScmListener.java:67)
      	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:123)
      	at org.jenkinsci.plugins.workflow.libs.SCMSourceRetriever.doRetrieve(SCMSourceRetriever.java:108)
      	at org.jenkinsci.plugins.workflow.libs.SCMSourceRetriever.retrieve(SCMSourceRetriever.java:84)
      	at org.jenkinsci.plugins.workflow.libs.LibraryAdder.retrieve(LibraryAdder.java:150)
      	at org.jenkinsci.plugins.workflow.libs.LibraryAdder.add(LibraryAdder.java:131)
      	at org.jenkinsci.plugins.workflow.libs.LibraryDecorator$1.call(LibraryDecorator.java:114)
      	at org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1053)
      	at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:591)
      	at org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:569)
      	at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:546)
      	at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:298)
      	at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:268)
      	at groovy.lang.GroovyShell.parseClass(GroovyShell.java:688)
      	at groovy.lang.GroovyShell.parse(GroovyShell.java:700)
      	at org.jenkinsci.plugins.workflow.cps.CpsGroovyShell.reparse(CpsGroovyShell.java:67)
      	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.parseScript(CpsFlowExecution.java:430)
      	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.start(CpsFlowExecution.java:393)
      	at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:238)
      	at hudson.model.ResourceController.execute(ResourceController.java:98)
      	at hudson.model.Executor.run(Executor.java:405)
      

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            While that patch may well have solved some bug, it did not solve this one, which is still trivially reproducible after

            diff --git a/demo/plugins.txt b/demo/plugins.txt
            index 24552af..bee898d 100644
            --- a/demo/plugins.txt
            +++ b/demo/plugins.txt
            @@ -2,7 +2,7 @@ org.jenkins-ci.ui:ace-editor:1.1
             org.jenkins-ci.plugins:ansicolor:0.5.0
             org.jenkins-ci.plugins:authentication-tokens:1.3
             io.jenkins.blueocean:blueocean:1.0.1
            -org.jenkins-ci.plugins:blueocean-autofavorite:0.7
            +org.jenkins-ci.plugins:blueocean-autofavorite:1.0.0
             io.jenkins.blueocean:blueocean-commons:1.0.1
             io.jenkins.blueocean:blueocean-config:1.0.1
             io.jenkins.blueocean:blueocean-dashboard:1.0.1
            
            Show
            jglick Jesse Glick added a comment - While that patch may well have solved some bug, it did not solve this one, which is still trivially reproducible after diff --git a/demo/plugins.txt b/demo/plugins.txt index 24552af..bee898d 100644 --- a/demo/plugins.txt +++ b/demo/plugins.txt @@ -2,7 +2,7 @@ org.jenkins-ci.ui:ace-editor:1.1 org.jenkins-ci.plugins:ansicolor:0.5.0 org.jenkins-ci.plugins:authentication-tokens:1.3 io.jenkins.blueocean:blueocean:1.0.1 -org.jenkins-ci.plugins:blueocean-autofavorite:0.7 +org.jenkins-ci.plugins:blueocean-autofavorite:1.0.0 io.jenkins.blueocean:blueocean-commons:1.0.1 io.jenkins.blueocean:blueocean-config:1.0.1 io.jenkins.blueocean:blueocean-dashboard:1.0.1
            Hide
            jglick Jesse Glick added a comment -

            See PR 9 for proper diagnostics, and discussion of what an actual fix might consist of.

            Show
            jglick Jesse Glick added a comment - See PR 9 for proper diagnostics, and discussion of what an actual fix might consist of.
            Hide
            jglick Jesse Glick added a comment -

            (and please do not close again without confirming a fix in the originally supplied test case)

            Show
            jglick Jesse Glick added a comment - (and please do not close again without confirming a fix in the originally supplied test case)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/io/jenkins/blueocean/autofavorite/FavoritingScmListener.java
            http://jenkins-ci.org/commit/blueocean-autofavorite-plugin/398fc00bc2d4b3caab4d62dd347a43147103ed6d
            Log:
            JENKINS-43400 Print the error to the build log rather than swallowing it. (#9)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/io/jenkins/blueocean/autofavorite/FavoritingScmListener.java http://jenkins-ci.org/commit/blueocean-autofavorite-plugin/398fc00bc2d4b3caab4d62dd347a43147103ed6d Log: JENKINS-43400 Print the error to the build log rather than swallowing it. (#9)
            Hide
            manus manus added a comment -

            Hello! Since this last change, our logs have been flooded with this message ("Unexpected error when retrieving changeset"), which makes it much more difficult to see other "Severe" logs.

            I think that alone should elevate this issue from "Minor" to at least "Major" priority. Is there any plan to reinvestigate the possible root cause of the issue and fix it? Or, as a stop-gap measure, change the logging level to WARN?

            Show
            manus manus added a comment - Hello! Since this last change, our logs have been flooded with this message ("Unexpected error when retrieving changeset"), which makes it much more difficult to see other "Severe" logs. I think that alone should elevate this issue from "Minor" to at least "Major" priority. Is there any plan to reinvestigate the possible root cause of the issue and fix it? Or, as a stop-gap measure, change the logging level to WARN?

              People

              • Assignee:
                Unassigned
                Reporter:
                jglick Jesse Glick
              • Votes:
                3 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated: