Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4354

Make Hudson user names case insensitive

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Environment:
      Platform: Other, OS: All
    • Similar Issues:

      Description

      As of now the names of users (id) are case sensitive. Retrieving user "name" and
      "Name" returns different User objects. Each user data is then stored in separete
      folders; "users/name/" and "users/Name". This is fine on linux as files are case
      sensitive, but not so good on Windows as file names are case insensitive.

      On Windows the user "Name" and "name", will be different users but after a
      server restart they will be populated with the same data. It is the same data as
      both user objects has been loaded with data from the "users/name" folder. So
      this means that on Windows, the user objects should be the same as they contain
      the same data.

      The background to this enhancement is that I have two issues reported on the ci-
      game (3990 and 4350). Depending on how people log in to a machine, they will
      have different casing on their user name. This is fine, but the big problem (in
      my eyes) is that Hudson stores two different user's data in one folder. Therefore I think Hudson should treat user names case insensitive, as the users
      is the same person (ie same data after a restart).

      The effect of this change would be small as I dont think there are no hudson
      installations that have users with different casing in their names and still
      would like to make a distinction between them.

        Attachments

          Issue Links

            Activity

            Hide
            aschilling Andreas Schilling added a comment -

            we're having the same issue as O H, so +1

            Show
            aschilling Andreas Schilling added a comment - we're having the same issue as O H, so +1
            Show
            cforce cforce added a comment - - edited Please fix, there so many different requests! Related/Dupe to https://issues.jenkins-ci.org/browse/JENKINS-3218 https://issues.jenkins-ci.org/browse/JENKINS-6377 https://issues.jenkins-ci.org/browse/JENKINS-4354 https://issues.jenkins-ci.org/browse/JENKINS-4354 https://issues.jenkins-ci.org/browse/JENKINS-4550 https://issues.jenkins-ci.org/browse/JENKINS-5436
            Hide
            hikerguy1900 Eric Blom added a comment -

            +1 for a fix for this.

            Show
            hikerguy1900 Eric Blom added a comment - +1 for a fix for this.
            Hide
            stephenconnolly Stephen Connolly added a comment -

            This needs to be configurable. Making usernames case insensitive will raise a similar bug for Security Realms which are case sensitive.

            e.g. Unix login names are case sensitive (convention is to only use all lowercase, but they are actually case sensitive)

            e.g. Email addresses are permitted to be case sensitive (nobody really treats them as case sensitive but according to the RFC everything before the @ must be treated as case preserving as it may be case sensitive and only the receiving mailbox will have the correct knowledge)

            Worse still is that Jenkins sees Users who's ID differs only in case as being the same User object under some code paths and different User objects under other code paths.

            Show
            stephenconnolly Stephen Connolly added a comment - This needs to be configurable. Making usernames case insensitive will raise a similar bug for Security Realms which are case sensitive. e.g. Unix login names are case sensitive (convention is to only use all lowercase, but they are actually case sensitive) e.g. Email addresses are permitted to be case sensitive (nobody really treats them as case sensitive but according to the RFC everything before the @ must be treated as case preserving as it may be case sensitive and only the receiving mailbox will have the correct knowledge) Worse still is that Jenkins sees Users who's ID differs only in case as being the same User object under some code paths and different User objects under other code paths.
            Hide
            oleg_nenashev Oleg Nenashev added a comment - - edited

            Fixed in JENKINS-22247 (jenkins-1.566+)

            Show
            oleg_nenashev Oleg Nenashev added a comment - - edited Fixed in JENKINS-22247 (jenkins-1.566+)

              People

              • Assignee:
                Unassigned
                Reporter:
                redsolo redsolo
              • Votes:
                17 Vote for this issue
                Watchers:
                18 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: