Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4392

hudson-slave.xml does not escape spaces causing the service to not start

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Component/s: other
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      If a slave name has a space in it, the service cannot start. It created an
      element of XML like this:

      <arguments>-Xrs -jar "%BASE%\slave.jar" -jnlpUrl
      http://build.gotgenie.com:8090/computer/Windows XP VM/slave-agent.jnlp</arguments>

      so the jnlpUrl will only be "http://build.gotgenie.com:8090/computer/Windows"
      and the slave jar will get the rest as more arguments, failing the service.

      I tried quoting the URL, which allowed the service to work, but the slave never
      showed up online after a few minutes. I unquoted it, swapped the spaces with
      %20, and restarted the service and the slave showed up instantly.

        Attachments

          Activity

          Hide
          mindless Alan Harder added a comment -

          started

          Show
          mindless Alan Harder added a comment - started
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : mindless
          Path:
          trunk/hudson/main/core/src/main/java/hudson/lifecycle/WindowsSlaveInstaller.java
          http://fisheye4.cenqua.com/changelog/hudson/?cs=21556
          Log:
          [FIXED JENKINS-4392] call Util.rawEncode on slaveName in jnlp url

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/main/core/src/main/java/hudson/lifecycle/WindowsSlaveInstaller.java http://fisheye4.cenqua.com/changelog/hudson/?cs=21556 Log: [FIXED JENKINS-4392] call Util.rawEncode on slaveName in jnlp url

            People

            • Assignee:
              mindless Alan Harder
              Reporter:
              mcrooney mcrooney
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: