Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44112

Enable Remoting work dir by default in Java Web Start and JNLP Agent (JNLPLauncher)

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      • JNLPLauncher should pass the workDir param
      • Generated *.jnlp file should also provide the WorkDir Param

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/model/Slave.java
            core/src/main/java/hudson/slaves/JNLPLauncher.java
            core/src/main/java/hudson/util/ArgumentListBuilder.java
            core/src/main/java/jenkins/slaves/RemotingWorkDirSettings.java
            core/src/main/resources/hudson/slaves/JNLPLauncher/config.jelly
            core/src/main/resources/hudson/slaves/JNLPLauncher/main.jelly
            core/src/main/resources/hudson/slaves/SlaveComputer/slave-agent.jnlp.jelly
            core/src/main/resources/jenkins/slaves/RemotingWorkDirSettings/config.jelly
            core/src/main/resources/jenkins/slaves/RemotingWorkDirSettings/help-disabled.html
            core/src/main/resources/jenkins/slaves/RemotingWorkDirSettings/help-failIfWorkDirIsMissing.html
            core/src/main/resources/jenkins/slaves/RemotingWorkDirSettings/help-internalDir.html
            core/src/main/resources/jenkins/slaves/RemotingWorkDirSettings/help-workDirPath.html
            test/src/test/java/hudson/bugs/JnlpAccessWithSecuredHudsonTest.java
            test/src/test/java/hudson/slaves/JNLPLauncherTest.java
            test/src/test/java/hudson/tools/InstallerTranslatorTest.java
            test/src/test/java/jenkins/security/Security218Test.java
            test/src/test/resources/hudson/slaves/JNLPLauncherTest/testNoWorkDirMigration/config.xml
            test/src/test/resources/hudson/slaves/JNLPLauncherTest/testNoWorkDirMigration/nodes/Foo/config.xml
            http://jenkins-ci.org/commit/jenkins/9dc2cdbb4892ddfb1579658fc88b4018a1ad7d8a
            Log:
            JENKINS-44112 - Enable WorkDir in JNLPLauncher (#2945)

            • JENKINS-44112 - Enable Work Directories by defaul in new agents with JNLP launcher
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/Slave.java core/src/main/java/hudson/slaves/JNLPLauncher.java core/src/main/java/hudson/util/ArgumentListBuilder.java core/src/main/java/jenkins/slaves/RemotingWorkDirSettings.java core/src/main/resources/hudson/slaves/JNLPLauncher/config.jelly core/src/main/resources/hudson/slaves/JNLPLauncher/main.jelly core/src/main/resources/hudson/slaves/SlaveComputer/slave-agent.jnlp.jelly core/src/main/resources/jenkins/slaves/RemotingWorkDirSettings/config.jelly core/src/main/resources/jenkins/slaves/RemotingWorkDirSettings/help-disabled.html core/src/main/resources/jenkins/slaves/RemotingWorkDirSettings/help-failIfWorkDirIsMissing.html core/src/main/resources/jenkins/slaves/RemotingWorkDirSettings/help-internalDir.html core/src/main/resources/jenkins/slaves/RemotingWorkDirSettings/help-workDirPath.html test/src/test/java/hudson/bugs/JnlpAccessWithSecuredHudsonTest.java test/src/test/java/hudson/slaves/JNLPLauncherTest.java test/src/test/java/hudson/tools/InstallerTranslatorTest.java test/src/test/java/jenkins/security/Security218Test.java test/src/test/resources/hudson/slaves/JNLPLauncherTest/testNoWorkDirMigration/config.xml test/src/test/resources/hudson/slaves/JNLPLauncherTest/testNoWorkDirMigration/nodes/Foo/config.xml http://jenkins-ci.org/commit/jenkins/9dc2cdbb4892ddfb1579658fc88b4018a1ad7d8a Log: JENKINS-44112 - Enable WorkDir in JNLPLauncher (#2945) JENKINS-44112 - Enable Work Directories by defaul in new agents with JNLP launcher JENKINS-44112 - Add test for the legacy data migration JENKINS-44112 - Add test for API calls JENKINS-44112 - Apply new APIs within core and tests JENKINS-44112 - Cleanup tests JENKINS-44112 - Cleanup API of JNLPLauncher JENKINS-44112 - Address the leftover code review comments
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            The fix has been integrated towards Jenkins 2.72

            Show
            oleg_nenashev Oleg Nenashev added a comment - The fix has been integrated towards Jenkins 2.72
            Hide
            benh57 Ben Hines added a comment -

            The feature documentation for this is cut off on git hub. It just says ' Remoting work directory is a storage'. https://github.com/jenkinsci/remoting/blob/master/docs/workDir.md

             

             Is there a description of the feature explaining what it is?

            Show
            benh57 Ben Hines added a comment - The feature documentation for this is cut off on git hub. It just says ' Remoting work directory is a storage'. https://github.com/jenkinsci/remoting/blob/master/docs/workDir.md    Is there a description of the feature explaining what it is?
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Ben Hines There was a user-friendly documentation for Jenkins Changelogs, but it got truncated from what I see. It is just a storage, really. Once you enable it, Remoting starts writing logs to the disk. It also changes the default destination of JAR Cache changes. I will update the GitHub documentation to make it more explicit.

            Show
            oleg_nenashev Oleg Nenashev added a comment - Ben Hines There was a user-friendly documentation for Jenkins Changelogs, but it got truncated from what I see. It is just a storage, really. Once you enable it, Remoting starts writing logs to the disk. It also changes the default destination of JAR Cache changes. I will update the GitHub documentation to make it more explicit.
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Ben Hines Some bits of "why?" are here: https://github.com/jenkins-infra/jenkins.io/pull/1060/files. Will move them to the documentation

            Show
            oleg_nenashev Oleg Nenashev added a comment - Ben Hines Some bits of "why?" are here: https://github.com/jenkins-infra/jenkins.io/pull/1060/files . Will move them to the documentation

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: