Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44738

Windows installer to perform backup of jenkins.xml file

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: packaging
    • Labels:
      None
    • Similar Issues:

      Description

      As to now whenever you install Jenkins on Windows through the MSI installer, the jenkins.xml file (which configures the Windows service) is copied to the specified location without checking for its existence.

      If the installation is done over an already installed Jenkins, this file is overwritten, resulting in the user loosing any possible customization on it.

      This file needs to be copied on each installation, as it might change from one version to another version, but a backup of the previous file could be performed so that the user at least does not loose the changes.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Evaristo Gutiérrez
            Path:
            msi/jenkins.wxs
            http://jenkins-ci.org/commit/packaging/934d66d006d97095f45053f0e89850c4da31d032
            Log:
            JENKINS-44738 Detect if jenkins.xml file exists on installation dir and perform a backup if it does.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Evaristo Gutiérrez Path: msi/jenkins.wxs http://jenkins-ci.org/commit/packaging/934d66d006d97095f45053f0e89850c4da31d032 Log: JENKINS-44738 Detect if jenkins.xml file exists on installation dir and perform a backup if it does.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Evaristo Gutiérrez
            Path:
            msi/jenkins.wxs
            http://jenkins-ci.org/commit/packaging/8e681e21175fa0ea7e05691c759384097b15a060
            Log:
            JENKINS-44738 Use FileSystemObject.CopyFile() to copy instead of calling cmd.exe. Add suffix to backup file not to overwrite an existing one. Make installation not fail because a failure during the backup.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Evaristo Gutiérrez Path: msi/jenkins.wxs http://jenkins-ci.org/commit/packaging/8e681e21175fa0ea7e05691c759384097b15a060 Log: JENKINS-44738 Use FileSystemObject.CopyFile() to copy instead of calling cmd.exe. Add suffix to backup file not to overwrite an existing one. Make installation not fail because a failure during the backup.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Sam Van Oort
            Path:
            msi/jenkins.wxs
            http://jenkins-ci.org/commit/packaging/b3198e467bca520c21e89e2c34ed41597f1f925a
            Log:
            Merge pull request #99 from varyvol/JENKINS-44738

            JENKINS-44738 Windows installer to perform backup of jenkins.xml file

            Compare: https://github.com/jenkinsci/packaging/compare/84993c2d5ed4...b3198e467bca

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: msi/jenkins.wxs http://jenkins-ci.org/commit/packaging/b3198e467bca520c21e89e2c34ed41597f1f925a Log: Merge pull request #99 from varyvol/ JENKINS-44738 JENKINS-44738 Windows installer to perform backup of jenkins.xml file Compare: https://github.com/jenkinsci/packaging/compare/84993c2d5ed4...b3198e467bca

              People

              • Assignee:
                egutierrez Evaristo Gutierrez
                Reporter:
                egutierrez Evaristo Gutierrez
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: