Details

    • Similar Issues:

      Description

      Post JENKINS-43507 with SCM-API having non-trivial implementations of instantiable things, we should add @Symbol annotations to the relevant descriptors.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/jenkins/scm/impl/SingleSCMNavigator.java
            src/main/java/jenkins/scm/impl/SingleSCMSource.java
            src/main/java/jenkins/scm/impl/trait/RegexSCMHeadFilterTrait.java
            src/main/java/jenkins/scm/impl/trait/RegexSCMSourceFilterTrait.java
            src/main/java/jenkins/scm/impl/trait/WildcardSCMHeadFilterTrait.java
            src/main/java/jenkins/scm/impl/trait/WildcardSCMSourceFilterTrait.java
            src/test/java/jenkins/scm/impl/SymbolAnnotationsTest.java
            src/test/java/jenkins/scm/impl/mock/MockSCM.java
            src/test/java/jenkins/scm/impl/mock/MockSCMDiscoverBranches.java
            src/test/java/jenkins/scm/impl/mock/MockSCMDiscoverChangeRequests.java
            src/test/java/jenkins/scm/impl/mock/MockSCMDiscoverTags.java
            src/test/java/jenkins/scm/impl/mock/MockSCMNavigator.java
            src/test/java/jenkins/scm/impl/mock/MockSCMSource.java
            http://jenkins-ci.org/commit/scm-api-plugin/d16e1eb8afcb159881fdc1a797e7d2d44e595bd4
            Log:
            [FIXED JENKINS-44884] Add @Symbol annotations

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/jenkins/scm/impl/SingleSCMNavigator.java src/main/java/jenkins/scm/impl/SingleSCMSource.java src/main/java/jenkins/scm/impl/trait/RegexSCMHeadFilterTrait.java src/main/java/jenkins/scm/impl/trait/RegexSCMSourceFilterTrait.java src/main/java/jenkins/scm/impl/trait/WildcardSCMHeadFilterTrait.java src/main/java/jenkins/scm/impl/trait/WildcardSCMSourceFilterTrait.java src/test/java/jenkins/scm/impl/SymbolAnnotationsTest.java src/test/java/jenkins/scm/impl/mock/MockSCM.java src/test/java/jenkins/scm/impl/mock/MockSCMDiscoverBranches.java src/test/java/jenkins/scm/impl/mock/MockSCMDiscoverChangeRequests.java src/test/java/jenkins/scm/impl/mock/MockSCMDiscoverTags.java src/test/java/jenkins/scm/impl/mock/MockSCMNavigator.java src/test/java/jenkins/scm/impl/mock/MockSCMSource.java http://jenkins-ci.org/commit/scm-api-plugin/d16e1eb8afcb159881fdc1a797e7d2d44e595bd4 Log: [FIXED JENKINS-44884] Add @Symbol annotations
            Hide
            jamesdumay James Dumay added a comment -

            Stephen Connolly looks like its been merged. Ready to resolve this one?

            Show
            jamesdumay James Dumay added a comment - Stephen Connolly looks like its been merged. Ready to resolve this one?
            Hide
            stephenconnolly Stephen Connolly added a comment -

            Flagging the follow-up work

            Show
            stephenconnolly Stephen Connolly added a comment - Flagging the follow-up work
            Hide
            stephenconnolly Stephen Connolly added a comment -

            The SCM-API traits have @Symbol annotations and we have a follow-up issue for the other traits

            Show
            stephenconnolly Stephen Connolly added a comment - The SCM-API traits have @Symbol annotations and we have a follow-up issue for the other traits

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                stephenconnolly Stephen Connolly
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: