Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4491

Support for maven non-recursive modules resolution.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: maven-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: All

      Description

      When we perform a non-recursive subversion checkout/update of our source code
      (see issue 1311), hudson tries to resolve the sub-modules that do not exist
      since their "pom.xml" file have not been checked out. To resolve this problem it
      would be nice if Hudson support the maven option "N", "-non-recursive" in
      order to not recurs into sub-projects.

        Activity

        Hide
        pascalra pascalra added a comment -

        Created an attachment (id=916)
        This SVN patch file (hudson-1.323-non-recursive-modules-resolution.patch) has been made based on the Hudson version "1.323". It allows for each job to configure if the maven modules resolution has to be done recursively or not. If the user specify, in the "Goals and options" field of the "Build" section of the job configuration web page, the option "N" or "-non-recursive" then maven will not recurs into the sub-projects, i.e. will not resolve the modules recursively.

        Show
        pascalra pascalra added a comment - Created an attachment (id=916) This SVN patch file (hudson-1.323-non-recursive-modules-resolution.patch) has been made based on the Hudson version "1.323". It allows for each job to configure if the maven modules resolution has to be done recursively or not. If the user specify, in the "Goals and options" field of the "Build" section of the job configuration web page, the option " N" or " -non-recursive" then maven will not recurs into the sub-projects, i.e. will not resolve the modules recursively.
        Hide
        abayer abayer added a comment -

        I'd be more willing to consider this patch if it weren't for the configuration
        option - we've got an excess of configuration options already. If you tweak it
        to determine whether to parse modules based on if "N" or "-non-recursive" was
        specified in the goals, that'd be preferable. This is a pretty rare use case
        (multi-module, checking out parent but not child modules), so I'd want any
        changes for it to be as unobtrusive as possible.

        Show
        abayer abayer added a comment - I'd be more willing to consider this patch if it weren't for the configuration option - we've got an excess of configuration options already. If you tweak it to determine whether to parse modules based on if " N" or " -non-recursive" was specified in the goals, that'd be preferable. This is a pretty rare use case (multi-module, checking out parent but not child modules), so I'd want any changes for it to be as unobtrusive as possible.
        Hide
        pascalra pascalra added a comment -

        The patch does not add any new configuration option. It checks if among the
        maven goals and options the "-N" or "—non-recursive" was specified and perform,
        accordingly, the module resolution recursively or not.

        Show
        pascalra pascalra added a comment - The patch does not add any new configuration option. It checks if among the maven goals and options the "-N" or "—non-recursive" was specified and perform, accordingly, the module resolution recursively or not.
        Hide
        abayer abayer added a comment -

        Wow, I honestly have no idea how I misread that. I apologize. =) Let me review
        this - if it looks good, I'll apply it and it'll end up in 1.325.

        Show
        abayer abayer added a comment - Wow, I honestly have no idea how I misread that. I apologize. =) Let me review this - if it looks good, I'll apply it and it'll end up in 1.325.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in hudson
        User: : abayer
        Path:
        trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java
        trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
        trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenUtil.java
        trunk/hudson/main/test/src/test/java/hudson/maven/MavenMultiModuleTest.java
        trunk/www/changelog.html
        http://fisheye4.cenqua.com/changelog/hudson/?cs=21856
        Log:
        [FIXED JENKINS-4491] If Maven is called with non-recursive flags, submodules are no longer parsed.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : abayer Path: trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenUtil.java trunk/hudson/main/test/src/test/java/hudson/maven/MavenMultiModuleTest.java trunk/www/changelog.html http://fisheye4.cenqua.com/changelog/hudson/?cs=21856 Log: [FIXED JENKINS-4491] If Maven is called with non-recursive flags, submodules are no longer parsed.

          People

          • Assignee:
            Unassigned
            Reporter:
            pascalra pascalra
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: