Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45434

Add an avatar cache so that SCMs that providing fixed size avatars can convert to Jenkins native sizes

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Some SCMs do not have avatar URLs that support resizing. Provide an end-point that will cache and resize external avatars on behalf of an AvatarMetadataAction

      Acceptance criteria:

      • Cache should be size bounded to prevent excessive memory usage. Where remote images are large, they should be scaled down before being cached in order to reduce the memory footprint
      • Concurrent requests to fetch images from remote URLs should be capped
      • When a remote image is unavailable, a consistent placeholder avatar should be generated.
      • Resized avatar images should be served with suitable cache-control headers to ensure that images are retained in co-operating client browser caches for up to 24h

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugin/gitea/GiteaAvatar.java
          src/main/java/org/jenkinsci/plugin/gitea/GiteaAvatarCache.java
          http://jenkins-ci.org/commit/gitea-plugin/1428d8733016a19f0a206109ebd80fae8bb6a8e7
          Log:
          JENKINS-45434 Use common avatar caching service

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugin/gitea/GiteaAvatar.java src/main/java/org/jenkinsci/plugin/gitea/GiteaAvatarCache.java http://jenkins-ci.org/commit/gitea-plugin/1428d8733016a19f0a206109ebd80fae8bb6a8e7 Log: JENKINS-45434 Use common avatar caching service
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/scm/api/metadata/AvatarMetadataAction.java
          src/main/java/jenkins/scm/impl/avatars/AvatarCache.java
          src/test/java/jenkins/scm/impl/avatars/AvatarCacheTest.java
          http://jenkins-ci.org/commit/scm-api-plugin/800f171c7df6b00fc93e0bea43f03d7a2284574d
          Log:
          [FIXED JENKINS-45434] Adds a caching resizing avatar service

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/metadata/AvatarMetadataAction.java src/main/java/jenkins/scm/impl/avatars/AvatarCache.java src/test/java/jenkins/scm/impl/avatars/AvatarCacheTest.java http://jenkins-ci.org/commit/scm-api-plugin/800f171c7df6b00fc93e0bea43f03d7a2284574d Log: [FIXED JENKINS-45434] Adds a caching resizing avatar service
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/scm/api/metadata/AvatarMetadataAction.java
          src/main/java/jenkins/scm/impl/avatars/AvatarCache.java
          src/test/java/jenkins/scm/impl/avatars/AvatarCacheTest.java
          http://jenkins-ci.org/commit/scm-api-plugin/725d4b464588521fe7dbe265bf1fecb63d63dc8d
          Log:
          Merge pull request #44 from stephenc/jenkins-45434

          [FIXED JENKINS-45434] Adds a caching resizing avatar service

          Compare: https://github.com/jenkinsci/scm-api-plugin/compare/850d9d205fc6...725d4b464588

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/metadata/AvatarMetadataAction.java src/main/java/jenkins/scm/impl/avatars/AvatarCache.java src/test/java/jenkins/scm/impl/avatars/AvatarCacheTest.java http://jenkins-ci.org/commit/scm-api-plugin/725d4b464588521fe7dbe265bf1fecb63d63dc8d Log: Merge pull request #44 from stephenc/jenkins-45434 [FIXED JENKINS-45434] Adds a caching resizing avatar service Compare: https://github.com/jenkinsci/scm-api-plugin/compare/850d9d205fc6...725d4b464588
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugin/gitea/GiteaAvatar.java
          src/main/java/org/jenkinsci/plugin/gitea/GiteaAvatarCache.java
          http://jenkins-ci.org/commit/gitea-plugin/8c1683e896e5a9d48228752d78d7a7bec585b5e1
          Log:
          Merge pull request #1 from jenkinsci/jenkins-45434

          JENKINS-45434 Use common avatar caching service

          Compare: https://github.com/jenkinsci/gitea-plugin/compare/399b3b8b0371...8c1683e896e5

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugin/gitea/GiteaAvatar.java src/main/java/org/jenkinsci/plugin/gitea/GiteaAvatarCache.java http://jenkins-ci.org/commit/gitea-plugin/8c1683e896e5a9d48228752d78d7a7bec585b5e1 Log: Merge pull request #1 from jenkinsci/jenkins-45434 JENKINS-45434 Use common avatar caching service Compare: https://github.com/jenkinsci/gitea-plugin/compare/399b3b8b0371...8c1683e896e5

            People

            • Assignee:
              stephenconnolly Stephen Connolly
              Reporter:
              stephenconnolly Stephen Connolly
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: