Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45879

JL-19: "TimerTriggerChecker" seems to trigger incorrectly

    Details

    • Similar Issues:

      Description

      I have a job with a the following trigger condition

      #working hours, weekdays: 5 min
      H/5 7-20 * * 1-5

      # rest of time - once an hour
      ## out of working hours
      H 20-23 * * 1-5
      H 00-06 * * 1-5

      ## Sa/So
      H H * * 6-7

      All lines contain (at least) one 'H'.

      But the job gets flagged by "JL-19: TimerTriggerChecker". To me this seems incorrect.

       

       

        Attachments

          Issue Links

            Activity

            Hide
            v2v Victor Martinez added a comment -

            Thanks for your feedback, Can you please send me over the config.xml file?

             

            I cannot reproduce it locally thought, I've just tried with:

             

            But the checker doesn't prompt any errors though. 

            Cheers

             

            Show
            v2v Victor Martinez added a comment - Thanks for your feedback, Can you please send me over the config.xml file?   I cannot reproduce it locally thought, I've just tried with:   But the checker doesn't prompt any errors though.  Cheers  
            Hide
            robrizlav Roberto Rizzetto added a comment -

            Hello Victor,

            I'm Roberto and I'm working with Martin.

             

            The flag "JL-19" for the job mentioned by Martin can be cleared if removing the empty lines between the scheduling rules. 

            Blank lines at the end of the "schedule" field don't affect the problem.

             

            The following (image-2017-08-01-13-31-29-081.png) is ok for JenkinsLint

             

            The following  (image-2017-08-01-13-33-27-842.png) get "FL-19" flagged:

             

            Best Regards,

            Roberto

            Show
            robrizlav Roberto Rizzetto added a comment - Hello Victor, I'm Roberto and I'm working with Martin.   The flag "JL-19" for the job mentioned by Martin can be cleared if removing the empty lines between the scheduling rules.  Blank lines at the end of the "schedule" field don't affect the problem.   The following (image-2017-08-01-13-31-29-081.png) is ok for JenkinsLint   The following  (image-2017-08-01-13-33-27-842.png) get "FL-19" flagged:   Best Regards, Roberto
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Victor Martinez
            Path:
            src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerChecker.java
            src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java
            http://jenkins-ci.org/commit/jenkinslint-plugin/dd01a697d714655c0b1377a921e0fa7f7e6ba60d
            Log:
            JENKINS-45879 Fixing false positive with empty lines and return carries

            Change-Id: I0604d71b59c5866c69e7ff2185f3e1c821daad00

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Victor Martinez Path: src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerChecker.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java http://jenkins-ci.org/commit/jenkinslint-plugin/dd01a697d714655c0b1377a921e0fa7f7e6ba60d Log: JENKINS-45879 Fixing false positive with empty lines and return carries Change-Id: I0604d71b59c5866c69e7ff2185f3e1c821daad00
            Hide
            v2v Victor Martinez added a comment -

            Thanks for the feedback, I was able to reproduce it locally! 

            I'l work on this fix 

            Show
            v2v Victor Martinez added a comment - Thanks for the feedback, I was able to reproduce it locally!  I'l work on this fix 
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Victor Martinez
            Path:
            src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerChecker.java
            src/main/java/org/jenkins/ci/plugins/jenkinslint/utils/StringUtils.java
            src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java
            src/test/java/org/jenkins/ci/plugins/jenkinslint/utils/StringUtilsTestCase.java
            http://jenkins-ci.org/commit/jenkinslint-plugin/5f1409cde40a4c759cb17e1ef1a853f434bf1e49
            Log:
            JENKINS-45879 Fixing false positive (#23)

            • JENKINS-45879 Fixing false positive with empty lines and return carries

            Change-Id: I0604d71b59c5866c69e7ff2185f3e1c821daad00

            • Using String Utils and fixed Hash validation with Case Insensitive and also Return Carries with blank spaces
            • Added missing conercases such as NPE, since this is a String Library
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Victor Martinez Path: src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/utils/StringUtils.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/utils/StringUtilsTestCase.java http://jenkins-ci.org/commit/jenkinslint-plugin/5f1409cde40a4c759cb17e1ef1a853f434bf1e49 Log: JENKINS-45879 Fixing false positive (#23) JENKINS-45879 Fixing false positive with empty lines and return carries Change-Id: I0604d71b59c5866c69e7ff2185f3e1c821daad00 Using String Utils and fixed Hash validation with Case Insensitive and also Return Carries with blank spaces Added missing conercases such as NPE, since this is a String Library

              People

              • Assignee:
                v2v Victor Martinez
                Reporter:
                martinjost Martin Jost
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: