Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46051

Gradle Plugin cause dead loop with using ant plugin

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      gradle plugins would cause dead loop with using ant and gradle build when viewing the console output.

      the gradle plugins when loading the outline , its use 

      document.getElementById("console-outline-body")

      and it has the same id with ant。 

      outline = document.getElementById("console-outline-body")
      .getElementsByTagName('ul')[0];

      when I use ant first ,ant genreate the outline, but it doesnt has a ul tag.

      so the outline is always undefined,and cause a dead loop;

       

      the source code of the grade plugins 

      gradle-plugin/[src|https://github.com/jenkinsci/gradle-plugin/tree/master/src]/[main|https://github.com/jenkinsci/gradle-plugin/tree/master/src/main]/[resources|https://github.com/jenkinsci/gradle-plugin/tree/master/src/main/resources]/[hudson|https://github.com/jenkinsci/gradle-plugin/tree/master/src/main/resources/hudson]/[plugins|https://github.com/jenkinsci/gradle-plugin/tree/master/src/main/resources/hudson/plugins]/[gradle|https://github.com/jenkinsci/gradle-plugin/tree/master/src/main/resources/hudson/plugins/gradle]/GradleTaskNote/script.js

      if (!loading) { loading = true; var u = new Ajax.Updater(document.getElementById("side-panel"), rootURL + "/descriptor/hudson.plugins.gradle.GradleTaskNote/outline", {insertion: Insertion.Bottom, onComplete: function() { if (!u.success()) return; // we can't us onSuccess because that kicks in before onComplete outline = document.getElementById("console-outline-body") .getElementsByTagName('ul')[0]; loading = false; queue.each(handle); }}); }
      

       

       

        Attachments

          Activity

          Hide
          webwart H. Feldker added a comment - - edited

          We have the same issue, in order to clarify how a running job's console output looks like I attached a screenshot of the sidebar. It repeats as long as my firefox has memory, at the end the firefox console is displaying an out of memory error.

          We also are using ant and gradle together as mentioned in the description above.

          If there is anything that we can do to help to solve this issue please let me know. Thanks a lot!

          Show
          webwart H. Feldker added a comment - - edited We have the same issue, in order to clarify how a running job's console output looks like I attached a screenshot of the sidebar. It repeats as long as my firefox has memory, at the end the firefox console is displaying an out of memory error. We also are using ant and gradle together as mentioned in the description above. If there is anything that we can do to help to solve this issue please let me know. Thanks a lot!
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stefan Wolf
          Path:
          src/main/resources/hudson/plugins/gradle/GradleTaskNote/DescriptorImpl/outline.jelly
          src/main/resources/hudson/plugins/gradle/GradleTaskNote/script.js
          src/main/resources/hudson/plugins/gradle/GradleTaskNote/style.css
          http://jenkins-ci.org/commit/gradle-plugin/319f42a30a616dd2def1337776eec40a4c0d10df
          Log:
          Fix endless loop when used with Ant builder

          [FIXES JENKINS-46051]

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stefan Wolf Path: src/main/resources/hudson/plugins/gradle/GradleTaskNote/DescriptorImpl/outline.jelly src/main/resources/hudson/plugins/gradle/GradleTaskNote/script.js src/main/resources/hudson/plugins/gradle/GradleTaskNote/style.css http://jenkins-ci.org/commit/gradle-plugin/319f42a30a616dd2def1337776eec40a4c0d10df Log: Fix endless loop when used with Ant builder [FIXES JENKINS-46051]
          Hide
          wolfs Stefan Wolf added a comment -

          H. Feldker kyle ou I think I fixed the problem on master. Could you try it out? The .hpi file can be downloaded from https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fgradle-plugin/detail/master/42/artifacts.

          Thank you!

          Show
          wolfs Stefan Wolf added a comment - H. Feldker kyle ou I think I fixed the problem on master . Could you try it out? The .hpi file can be downloaded from https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fgradle-plugin/detail/master/42/artifacts . Thank you!
          Hide
          webwart H. Feldker added a comment -

          Stefan Wolf Thank you very much, I am going to try the update as soon as possible.

          Show
          webwart H. Feldker added a comment - Stefan Wolf Thank you very much, I am going to try the update as soon as possible.
          Hide
          webwart H. Feldker added a comment - - edited

          Stefan Wolf It definitely looks much better now!

          There is one thing I noticed, but maybe it was already existing before: The layout of the executed ant tasks seems a little out of place: the list bullets are located outside the box, the layout of the gradle task box is fine.

          Thanks a lot, now the console output of a running task is usable again!

          Greetings from Berlin!

          Show
          webwart H. Feldker added a comment - - edited Stefan Wolf It definitely looks much better now! There is one thing I noticed, but maybe it was already existing before: The layout of the executed ant tasks seems a little out of place: the list bullets are located outside the box, the layout of the gradle task box is fine. Thanks a lot, now the console output of a running task is usable again! Greetings from Berlin!
          Hide
          wolfs Stefan Wolf added a comment -

          Closing since I released 1.28 containing a fix for this issue.

          Show
          wolfs Stefan Wolf added a comment - Closing since I released 1.28 containing a fix for this issue.

            People

            • Assignee:
              wolfs Stefan Wolf
              Reporter:
              kyle_ou kyle ou
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: