Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46053

Maven Plugin should not bundle the obsolete Commons HTTP Client Library

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: maven-plugin
    • Labels:
      None
    • Similar Issues:

      Description

      I am working on replacing Commons HTTPClient 3.x in Jenkins core in order to get new API features. I discovered that Maven Plugin HPI includes this library as well. It comes as a transient dependency from the Maven Interceptors set of Libraries (in particular, https://github.com/jenkinsci/maven-interceptors/tree/master/maven-agent). From what we see, this library is actually not used in the plugin at all, so I propose to just delete it.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          maven-agent/pom.xml
          maven-interceptor/pom.xml
          http://jenkins-ci.org/commit/maven-interceptors/9a3fdb06441c269a0ddd825b07f1321507af8641
          Log:
          JENKINS-46053 - Remove Commons HttpClient 3.x from dependencies

          Maven Plugin has already migratde to Apache HttpClient 4.x, so there is no transient usages.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: maven-agent/pom.xml maven-interceptor/pom.xml http://jenkins-ci.org/commit/maven-interceptors/9a3fdb06441c269a0ddd825b07f1321507af8641 Log: JENKINS-46053 - Remove Commons HttpClient 3.x from dependencies Maven Plugin has already migratde to Apache HttpClient 4.x, so there is no transient usages.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          maven-agent/pom.xml
          maven-interceptor/pom.xml
          http://jenkins-ci.org/commit/maven-interceptors/0e23678b802abab2d35c66fbade03d2f21753d89
          Log:
          Merge pull request #13 from oleg-nenashev/JENKINS-46053-httpclient

          JENKINS-46053 - Remove Commons HttpClient 3.x from dependencies

          Compare: https://github.com/jenkinsci/maven-interceptors/compare/238f472e1a8f...0e23678b802a

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: maven-agent/pom.xml maven-interceptor/pom.xml http://jenkins-ci.org/commit/maven-interceptors/0e23678b802abab2d35c66fbade03d2f21753d89 Log: Merge pull request #13 from oleg-nenashev/ JENKINS-46053 -httpclient JENKINS-46053 - Remove Commons HttpClient 3.x from dependencies Compare: https://github.com/jenkinsci/maven-interceptors/compare/238f472e1a8f...0e23678b802a
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/maven-plugin/4826ae7bc381d3d10abefdd1e23864020e548422
          Log:
          [JENKINS-46053, JENKINS-45271] Update Parent POM.xml, pick dev versions of Apache HttpClient plugin and Maven Interceptors

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/maven-plugin/4826ae7bc381d3d10abefdd1e23864020e548422 Log: [JENKINS-46053, JENKINS-45271] Update Parent POM.xml, pick dev versions of Apache HttpClient plugin and Maven Interceptors
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Arnaud Heritier
          Path:
          pom.xml
          src/main/java/hudson/maven/MavenBuild.java
          src/test/java/hudson/maven/AbstractMaven3xBuildTest.java
          src/test/java/hudson/maven/Maven31xBuildTest.java
          src/test/java/hudson/maven/Maven339BuildTest.java
          src/test/java/hudson/maven/Maven35xBuildTest.java
          http://jenkins-ci.org/commit/maven-plugin/6891d0bee159ea9dd614b0a5d36a969820ca79bb
          Log:
          Merge pull request #102 from oleg-nenashev/facelift

          [JENKINS-46053, JENKINS-45271, JENKINS-46210, JENKINS-46148] - Update HttpClient libraries and Fix Parent POM

          Compare: https://github.com/jenkinsci/maven-plugin/compare/5a3d468d42d6...6891d0bee159

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Arnaud Heritier Path: pom.xml src/main/java/hudson/maven/MavenBuild.java src/test/java/hudson/maven/AbstractMaven3xBuildTest.java src/test/java/hudson/maven/Maven31xBuildTest.java src/test/java/hudson/maven/Maven339BuildTest.java src/test/java/hudson/maven/Maven35xBuildTest.java http://jenkins-ci.org/commit/maven-plugin/6891d0bee159ea9dd614b0a5d36a969820ca79bb Log: Merge pull request #102 from oleg-nenashev/facelift [JENKINS-46053, JENKINS-45271, JENKINS-46210, JENKINS-46148] - Update HttpClient libraries and Fix Parent POM Compare: https://github.com/jenkinsci/maven-plugin/compare/5a3d468d42d6...6891d0bee159
          Hide
          aheritier Arnaud Héritier added a comment -

          Fixed in 3.0(-rc1)

          Show
          aheritier Arnaud Héritier added a comment - Fixed in 3.0(-rc1)

            People

            • Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: