Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46104

Branch name field for `Commit to new branch` allows spaces, and probably shouldn't

    XMLWordPrintable

    Details

    • Sprint:
      Blue Ocean 1.4 - beta 1
    • Similar Issues:

      Description

      Summary:
      When saving a changed pipeline to a new branch in GitHub, the editor allows the user to provide a branch name with spaces in it.

      Steps to recreate:
      1. Edit an existing, functional pipeline with the editor. Make a trivial change.

      2. Click Save.

      3. Add a description, and select "Commit to new branch."

      4. Provide a branch name that contains spaces.

      5. Click "Save and run." You'll get "Error: Bad Request" when you try this.

      6. Remove the spaces from the branch name, and everything works fine.

      This isn't a high severity issue, but it seems like some field controls preventing users from trying to use spaces in their branch names might be helpful.

        Attachments

          Issue Links

            Activity

            Show
            nicu Nicolae Pascu added a comment - https://github.com/jenkinsci/blueocean-plugin/pull/1462
            Hide
            kshultz Karl Shultz added a comment -

            Testing Notes:

            • ATH has already been modified to test for this. Very nice.
            Show
            kshultz Karl Shultz added a comment - Testing Notes: ATH has already been modified to test for this. Very nice.

              People

              • Assignee:
                nicu Nicolae Pascu
                Reporter:
                kshultz Karl Shultz
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: