Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46252

Add property to determine that job is declarative or not

    XMLWordPrintable

    Details

    • Sprint:
      Declarative - 1.2
    • Similar Issues:

      Description

      Property should be present only when the pipeline is declarative

        Attachments

          Issue Links

            Activity

            Hide
            abayer Andrew Bayer added a comment -

            So what's actually desired here, if I'm remembering correctly, is a JobProperty.

            Show
            abayer Andrew Bayer added a comment - So what's actually desired here, if I'm remembering correctly, is a JobProperty .
            Hide
            abayer Andrew Bayer added a comment -

            So once https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/222 is merged and released (presumably in 1.2.5), every job that's ever had a Declarative run will have a DeclarativeJobAction on it. The action itself has nothing to it, it's just a marker.

            Show
            abayer Andrew Bayer added a comment - So once https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/222 is merged and released (presumably in 1.2.5), every job that's ever had a Declarative run will have a DeclarativeJobAction on it. The action itself has nothing to it, it's just a marker.
            Hide
            abayer Andrew Bayer added a comment -

            Done, will be releasing today as Declarative 1.2.5.

            Show
            abayer Andrew Bayer added a comment - Done, will be releasing today as Declarative 1.2.5.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/RuntimeASTTransformer.groovy
            pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/actions/DeclarativeJobAction.java
            pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BasicModelDefTest.java
            http://jenkins-ci.org/commit/pipeline-model-definition-plugin/4ef849e15f96ec234fe39d7314a27789d3eb8bee
            Log:
            [FIXED JENKINS-46252] Mark Declarative jobs with DeclarativeJobAction

            If we are in a Declarative run, mark the parent job as a Declarative
            job via DeclarativeJobAction, if it's not already present. Note that
            we never remove this - if a job was ever once Declarative, we still
            count it as such. Imperfect, but close enough.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/RuntimeASTTransformer.groovy pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/actions/DeclarativeJobAction.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BasicModelDefTest.java http://jenkins-ci.org/commit/pipeline-model-definition-plugin/4ef849e15f96ec234fe39d7314a27789d3eb8bee Log: [FIXED JENKINS-46252] Mark Declarative jobs with DeclarativeJobAction If we are in a Declarative run, mark the parent job as a Declarative job via DeclarativeJobAction, if it's not already present. Note that we never remove this - if a job was ever once Declarative, we still count it as such. Imperfect, but close enough.

              People

              • Assignee:
                abayer Andrew Bayer
                Reporter:
                jamesdumay James Dumay
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: