Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46945

Run.duration is calculated after RunListener.fireCompleted in WorkflowRun whereas it is calculated before in core Jenkins' Run class

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      In core Jenkins (for non-pipeline jobs) the duration of a run is calculated and stored before RunListener.fireCompleted(Run, Listener) is invoked whereas in workflow-job-plugin the duration is calculated after RunListener.fireCompleted is invoked but before FlowExecutionListener.fireCompleted is invoked.

      Is this intentional?

      Are you implying that, as a plugin developer, I should I be creating a RunListener<AbstractBuild> and a FlowExecutionListener<WorkflowRun>? I would guess not since the net effect would be somewhat different in timing calculations. In other words, FlowExecutionListener's duration of Run would effectively increase the time cost of running all of the RunListeners.

      WorkflowRun code

      Core Jenkins Run code

       

      In short, this PR gives us better metrics and a consistent interface to get build time metrics.

      Scenario:

      MyRunListener implements RunListener.onCompleted() to do something with duration. Here are the results before this change in MyRunListener.onCompleted: 

      WorkflowRun.duration: always 0

      hudson.model.Run.duration: calculated based on start and end time.

      So, essentially, there is an inconsistency in the expectation of duration being available and the fact that a RunListener would need to calculate the duration puts the RunListener in a situation where they may not be calculating it in a consistent moment.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Sam Van Oort
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
            src/test/java/org/jenkinsci/plugins/workflow/job/WorkflowRunTest.java
            http://jenkins-ci.org/commit/workflow-job-plugin/bf99a3d518221954e88a317ee1ef0f2a67139409
            Log:
            Merge pull request #72 from justinharringa/JENKINS-46945

            JENKINS-46945 Run duration set before RunListener.fireCompleted

            Compare: https://github.com/jenkinsci/workflow-job-plugin/compare/74985c022ed5...bf99a3d51822

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java src/test/java/org/jenkinsci/plugins/workflow/job/WorkflowRunTest.java http://jenkins-ci.org/commit/workflow-job-plugin/bf99a3d518221954e88a317ee1ef0f2a67139409 Log: Merge pull request #72 from justinharringa/ JENKINS-46945 JENKINS-46945 Run duration set before RunListener.fireCompleted Compare: https://github.com/jenkinsci/workflow-job-plugin/compare/74985c022ed5...bf99a3d51822
            Hide
            justinharringa Justin Harringa added a comment -

            Fixed in version 2.16

            Show
            justinharringa Justin Harringa added a comment - Fixed in version 2.16

              People

              • Assignee:
                justinharringa Justin Harringa
                Reporter:
                justinharringa Justin Harringa
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: