Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4702

Support module filtering in MercurialChangeSetList

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: mercurial-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      Since the "module" is not considered in the MercurialChangeSetList, all
      changesets in the repository will be applied to buildjob i Hudson even if they
      are not affecting the module.
      The proposed patch (from 1.22 tag) filters changessets with no changes in the
      given module when parsing the changeset file.

        Attachments

        1. patch.txt
          37 kB
        2. patch.txt
          37 kB

          Activity

          Hide
          sunfire sunfire added a comment -

          Created an attachment (id=961)
          Proposed patch

          Show
          sunfire sunfire added a comment - Created an attachment (id=961) Proposed patch
          Hide
          sunfire sunfire added a comment -

          Created an attachment (id=962)
          The corrected version...

          Show
          sunfire sunfire added a comment - Created an attachment (id=962) The corrected version...
          Hide
          jglick Jesse Glick added a comment -

          I should probably be default owner of this subcomponent...

          Show
          jglick Jesse Glick added a comment - I should probably be default owner of this subcomponent...
          Hide
          jglick Jesse Glick added a comment -

          Reporter - in the future please do not submit patches with unrelated changes to
          code, such as reformatting. This makes it nearly impossible to review what you
          are actually changing, thus what regressions your change might cause. A patch
          should be as short as possible to accomplish the desired change in behavior.

          Also patches without accompanying tests are less likely to be applied quickly.

          In this case it seems that the only actual change is to add
          filterChangesSetForModule and call it from the end of parse. I think I can take
          it from there.

          Show
          jglick Jesse Glick added a comment - Reporter - in the future please do not submit patches with unrelated changes to code, such as reformatting. This makes it nearly impossible to review what you are actually changing, thus what regressions your change might cause. A patch should be as short as possible to accomplish the desired change in behavior. Also patches without accompanying tests are less likely to be applied quickly. In this case it seems that the only actual change is to add filterChangesSetForModule and call it from the end of parse. I think I can take it from there.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : jglick
          Path:
          trunk/hudson/plugins/mercurial/src/main/java/hudson/plugins/mercurial/MercurialChangeLogParser.java
          trunk/hudson/plugins/mercurial/src/main/java/hudson/plugins/mercurial/MercurialSCM.java
          trunk/hudson/plugins/mercurial/src/test/java/hudson/plugins/mercurial/MercurialSCMTest.java
          http://fisheye4.cenqua.com/changelog/hudson/?cs=23101
          Log:
          [FIXED JENKINS-4702] Omit changesets from changelog if a module list has been specified and they do not match.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : jglick Path: trunk/hudson/plugins/mercurial/src/main/java/hudson/plugins/mercurial/MercurialChangeLogParser.java trunk/hudson/plugins/mercurial/src/main/java/hudson/plugins/mercurial/MercurialSCM.java trunk/hudson/plugins/mercurial/src/test/java/hudson/plugins/mercurial/MercurialSCMTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=23101 Log: [FIXED JENKINS-4702] Omit changesets from changelog if a module list has been specified and they do not match.

            People

            • Assignee:
              jglick Jesse Glick
              Reporter:
              sunfire sunfire
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: