Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47391

Swarm plugin with -labelsFile does not delete removed labels

    Details

    • Similar Issues:
    • Released As:
      3.15

      Description

      Code on the Jenkins plugin side responsible for label removing has been commented out during cleanup.
      https://github.com/jenkinsci/swarm-plugin/blame/master/plugin/src/main/java/hudson/plugins/swarm/PluginImpl.java#L144

      To reproduce:
      run swarm jar with -labelsFile option, modify label string in the file (add a new label and remove some existing label), wait for 10 seconds, go to the agent's page in Jenkins.
      The new label will appear, but the deleted one will remain.

        Attachments

          Activity

          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Wow, the previous maintainer just commented it out when fixing FindBugs: https://github.com/jenkinsci/swarm-plugin/commit/67e9d17408c44ddb0778cc4256884245942e32b0

          Show
          oleg_nenashev Oleg Nenashev added a comment - Wow, the previous maintainer just commented it out when fixing FindBugs: https://github.com/jenkinsci/swarm-plugin/commit/67e9d17408c44ddb0778cc4256884245942e32b0
          Hide
          basil Basil Crow added a comment -

          This was fixed in #75 and released in 3.15.

          Show
          basil Basil Crow added a comment - This was fixed in #75 and released in 3.15.

            People

            • Assignee:
              Unassigned
              Reporter:
              nickolayr Nickolay Rumyantsev
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: