Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47673

Current BO Master forces third party bo based plugins to use the exact versions of npm deps

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      Blue Ocean 1.4 - beta 3, Blue Ocean 1.4 - beta 2

      Description

      Since the move to hpi based jdl et. al. custom plugins are forced to sync any given dependency that is coming from BO in your plugin package.json so that you use the *exact* version as BO does.

      If not you get blank screen and some error of "0 of undefined" and then you see e.g. "react-router" involved so you need to look into your version and theirs of "react-router".

      Once you have it, you have to keep the dependency of BO on your watch to adopt when they do.

      Prior to the change the dep resolving did neither worked correctly in returning you the version BO uses and not the one you requested but at least in 90% of the cases the plugin would have still worked.

      The problem here as I see it, is it forces plugin developer to release plugins on a fixed BO version and every time BO does a new release, meaning keeping backward compatibility is becoming impossible.

        Attachments

          Issue Links

            Activity

            Hide
            michaelneale Michael Neale added a comment -

            Thorsten Scherler yes, if this is the case, this does seem bad (ie in the past you didn't quite get the version you wanted right, but you would get "a version" right?)

            Show
            michaelneale Michael Neale added a comment - Thorsten Scherler yes, if this is the case, this does seem bad (ie in the past you didn't quite get the version you wanted right, but you would get "a version" right?)
            Hide
            kzantow Keith Zantow added a comment -

            Michael Neale no, in the past we had latent bugs because we had multiple things bundled and duplicated objects being passed around in unexpected ways.

            Show
            kzantow Keith Zantow added a comment - Michael Neale no, in the past we had latent bugs because we had multiple things bundled and duplicated objects being passed around in unexpected ways.
            Hide
            michaelneale Michael Neale added a comment -

            Keith Zantow so is  resolvable ?- ie it won't fuss if the third party plugin deps don't match up 100%? 

            Show
            michaelneale Michael Neale added a comment - Keith Zantow so is  resolvable ?- ie it won't fuss if the third party plugin deps don't match up 100%? 
            Hide
            tscherler Thorsten Scherler added a comment -

            > unexpected ways

            beats completely broken everytime

            Michael Neale you have summarized it well.

            Show
            tscherler Thorsten Scherler added a comment - > unexpected ways beats completely broken everytime Michael Neale you have summarized it well.
            Hide
            michaelneale Michael Neale added a comment -

            Thorsten Scherler it may just be react router, but Keith Zantow is looking into it, obviously not intended. 

            Show
            michaelneale Michael Neale added a comment - Thorsten Scherler it may just be react router, but Keith Zantow is looking into it, obviously not intended. 
            Hide
            alobato Alvaro Lobato added a comment -

            I've linked a document that seems relevant to this issue.

            Show
            alobato Alvaro Lobato added a comment - I've linked a document that seems relevant to this issue.
            Hide
            tscherler Thorsten Scherler added a comment -

            I doubt that it is only react-router, since the error I saw had come from the bundle the router had been just an example

            Show
            tscherler Thorsten Scherler added a comment - I doubt that it is only react-router, since the error I saw had come from the bundle the router had been just an example
            Hide
            tscherler Thorsten Scherler added a comment -

            Alvaro Lobato yes I think the doc explains the problem we see point on.

            Show
            tscherler Thorsten Scherler added a comment - Alvaro Lobato yes I think the doc explains the problem we see point on.
            Hide
            michaelneale Michael Neale added a comment -

            Keith Zantow this one may be done now the shrinkwrap files went back in right? 

            Show
            michaelneale Michael Neale added a comment - Keith Zantow this one may be done now the shrinkwrap files went back in right? 
            Hide
            kshultz Karl Shultz added a comment -

            Testing Notes:

            • This isn't something that can be tested within Blue Ocean itself, because the problem stems from custom plugins which rely upon, or extend, Blue Ocean itself.
            Show
            kshultz Karl Shultz added a comment - Testing Notes: This isn't something that can be tested within Blue Ocean itself, because the problem stems from custom plugins which rely upon, or extend, Blue Ocean itself.
            Hide
            michaelneale Michael Neale added a comment -

            still a WIP - keith working very hard at it.. .this is marked as a blocker and getting the attention it needs. 

            Show
            michaelneale Michael Neale added a comment - still a WIP - keith working very hard at it.. .this is marked as a blocker and getting the attention it needs. 
            Hide
            alobato Alvaro Lobato added a comment -

            Michael Neale and Keith Zantow thanks for the effort!!!

            Show
            alobato Alvaro Lobato added a comment - Michael Neale and Keith Zantow thanks for the effort!!!

              People

              • Assignee:
                kzantow Keith Zantow
                Reporter:
                tscherler Thorsten Scherler
              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: