Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47859

`Automatic branch project triggering » Branch names to build automatically` must die

    XMLWordPrintable

    Details

    • Similar Issues:
    • Released As:
      2.1.0

      Description

      The `Automatic branch project triggering » Branch names to build automatically` property was a hack.

      The correct way to implement that feature would be using a BranchBuildStrategy as that will correctly suppress. We should remove the property... the correct path to removal will look something like this:

      1. Create an extension plugin for Branch API that implements at least BranchBuildStrategy based on matching the branch name
      2. Add a migration to Branch API that removes the NoTriggerBranchProperty property and replaces it with the BranchBuildStrategy (by magic, as we cannot have circular dependencies)
      3. Add some magic that auto-installs the branch build strategy plugin only if the migration is needed (so that regular users are not confused by more configuration options until they install the plugins enabling same)

      What we'll probably have to do is more complex:

      1. Create an extension point to migrate the NoTriggerBranchProperty (no implementations in branch-api
      2. Create an administrative monitor that alerts to install the branch build strategy plugin if a migration is required
      3. Disable adding the NoTriggerBranchProperty via the UI, but allow maintaining an existing configuration
      4. At some future date, remove the NoTriggerBranchProperty entirely

        Attachments

          Issue Links

            Activity

            Hide
            stephenconnolly Stephen Connolly added a comment -

            Removing myself as assignee. My current work assignments do not provide sufficient bandwidth to review these issues and in the majority of cases I am only assigned by virtue of being the default assignee. For the credentials-api and scm-api related plugins I have permission to allocate time reviewing changes to these APIs themselves to ensure these APIs remain cohesive, but that can be handled through PR reviews rather than assigning issues in JIRA

            Show
            stephenconnolly Stephen Connolly added a comment - Removing myself as assignee. My current work assignments do not provide sufficient bandwidth to review these issues and in the majority of cases I am only assigned by virtue of being the default assignee. For the credentials-api and scm-api related plugins I have permission to allocate time reviewing changes to these APIs themselves to ensure these APIs remain cohesive, but that can be handled through PR reviews rather than assigning issues in JIRA

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                stephenconnolly Stephen Connolly
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: