Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47908

After upgrade to v2.0, the active choices updates randomly in the browser

    Details

    • Similar Issues:

      Description

      Hello,

      I used Active choices parameters version 1.5.2 in a production environment since yesterday.
      I updated the server and got version 2.0, whitelisted the necessary java methods and then tested the new behaviour of the "build with parameters" page.

      When I modify a parameter's value, the other parameters updates only randomly, or partially (some are up to date, while the other not). The page sometimes blinked while updating, in which case more parameters were up to date (seems like an async bug to me).

      My setup is :
      Action : build_partial/build_full
      Part : part1/part2:selected/part3/full   => full is display when build_full is chosen and replaces the other choices
      Subpart : subpart1/subpart2/subpart3    => subparts are displayes only for part2
      Other fields that are empty if action is build_full.

      Then I rolled back to 1.5.2 and everything worked fine again.

        Attachments

          Issue Links

            Activity

            Hide
            kinow Bruno P. Kinoshita added a comment -

            Ioannis Moutsatsos, attaching uno-choice.hpi (de4ab1b29fd32361f447cbd153900bdb). Ready to be tested!

            Show
            kinow Bruno P. Kinoshita added a comment - Ioannis Moutsatsos , attaching uno-choice.hpi (de4ab1b29fd32361f447cbd153900bdb). Ready to be tested!
            Hide
            klimas7 Boguslaw Klimas added a comment -

            Hi Bruno,

            I tested this issue, and its ok. Plugin work fine.

            Boguslaw

            Show
            klimas7 Boguslaw Klimas added a comment - Hi Bruno, I tested this issue, and its ok. Plugin work fine. Boguslaw
            Hide
            kinow Bruno P. Kinoshita added a comment -

            Hi Boguslaw!

            One of the fastest replies I ever got in all my time in open source thanks for the feedback!!!

            Bruno

            Show
            kinow Bruno P. Kinoshita added a comment - Hi Boguslaw! One of the fastest replies I ever got in all my time in open source thanks for the feedback!!! Bruno
            Hide
            ioannis Ioannis Moutsatsos added a comment - - edited

            Bruno P. Kinoshita Thanks for making the hpi available for testing!

            The new plugin requires Jenkins v 2.46.3 or later. That is due to the new security framework.

            After I upgraded my Jenkins instance to v 2.93 (latest at the moment) and Active Choices v2.0 (patch) the parameter synchonization issue seems fixed. THANKS!

             

            However, HTML in parameter descriptions is no longer rendered.

            Here is an example

            Not sure whether this is fixable in Active Choices or some other Jenkins security setting. But it was fixed  for a related parameter type.

            https://issues.jenkins-ci.org/browse/JENKINS-42903

            I rely a lot on HTML in descriptions (even dynamically changing them with AC parameters)  and this is a blocker for several of my Jenkins projects. 

            I will need to wait for a patch on this before I can deploy to production. I will also open another JIRA issue.

            Show
            ioannis Ioannis Moutsatsos added a comment - - edited Bruno P. Kinoshita Thanks for making the hpi available for testing! The new plugin requires Jenkins v 2.46.3 or later. That is due to the new security framework. After I upgraded my Jenkins instance to v 2.93 (latest at the moment) and Active Choices v2.0 (patch) the parameter synchonization issue seems fixed. THANKS!   However, HTML in parameter descriptions is no longer rendered . Here is an example Not sure whether this is fixable in Active Choices or some other Jenkins security setting. But it was fixed  for a related parameter type. https://issues.jenkins-ci.org/browse/JENKINS-42903 I rely a lot on HTML in descriptions (even dynamically changing them with AC parameters)  and this is a blocker for several of my Jenkins projects.  I will need to wait for a patch on this before I can deploy to production. I will also open another JIRA issue.
            Hide
            kinow Bruno P. Kinoshita added a comment -

            Hi Ioannis!

            Thanks for testing it so quickly. Perhaps we can work on a patch for this one too? First I will investigate if we can enable the HTML for those fields.

            From what I remember, we now have HTML being escaped through a dependency added to pom.xml. There should be a way to tell Jenkins/this dependency that we know what we are doing in certain cases... or which tags we want.

            But I haven't tested it yet. After you create the new JIRA issue for that, if you could include a simple config.xml, I'll then use it for testing & patching the code.

            Bruno

            Show
            kinow Bruno P. Kinoshita added a comment - Hi Ioannis! Thanks for testing it so quickly. Perhaps we can work on a patch for this one too? First I will investigate if we can enable the HTML for those fields. From what I remember, we now have HTML being escaped through a dependency added to pom.xml. There should be a way to tell Jenkins/this dependency that we know what we are doing in certain cases... or which tags we want. But I haven't tested it yet. After you create the new JIRA issue for that, if you could include a simple config.xml, I'll then use it for testing & patching the code. Bruno

              People

              • Assignee:
                kinow Bruno P. Kinoshita
                Reporter:
                kiruahxh Kiruahxh
              • Votes:
                8 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: