Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48133

ChannelClosedException should Record channel name/info when possible

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: remoting
    • Labels:
      None
    • Similar Issues:

      Description

      Currently "ChannelClosedException" does not hold the name of the channel, so sometimes in diagnostics logging it's hard to diagnose from which channel it comes.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/remoting/Callable.java
          src/main/java/hudson/remoting/Channel.java
          src/main/java/hudson/remoting/ChannelClosedException.java
          src/main/java/hudson/remoting/Request.java
          src/main/java/org/jenkinsci/remoting/ChannelStateException.java
          src/main/java/org/jenkinsci/remoting/protocol/impl/ChannelApplicationLayer.java
          http://jenkins-ci.org/commit/remoting/86d4f80cc5babf5d23a9967e255aca52be9b3a35
          Log:
          JENKINS-48133 - ChannelStateException now recoreds channel name and info when possible.

          ChannelStateException has not been released yet, so the API compatibility is not broken.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/remoting/Callable.java src/main/java/hudson/remoting/Channel.java src/main/java/hudson/remoting/ChannelClosedException.java src/main/java/hudson/remoting/Request.java src/main/java/org/jenkinsci/remoting/ChannelStateException.java src/main/java/org/jenkinsci/remoting/protocol/impl/ChannelApplicationLayer.java http://jenkins-ci.org/commit/remoting/86d4f80cc5babf5d23a9967e255aca52be9b3a35 Log: JENKINS-48133 - ChannelStateException now recoreds channel name and info when possible. ChannelStateException has not been released yet, so the API compatibility is not broken.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/remoting/Callable.java
          src/main/java/hudson/remoting/Channel.java
          src/main/java/hudson/remoting/ChannelClosedException.java
          src/main/java/hudson/remoting/Request.java
          src/main/java/org/jenkinsci/remoting/ChannelStateException.java
          src/main/java/org/jenkinsci/remoting/protocol/impl/ChannelApplicationLayer.java
          http://jenkins-ci.org/commit/remoting/5412f2864878ea1ab96c8e58851e37d0638a6938
          Log:
          Merge pull request #235 from oleg-nenashev/feature/JENKINS-48133_channelStateEx_diagnosability

          JENKINS-48133 - ChannelClosedException and ChannelStateException now record channel name and info when possible.

          Compare: https://github.com/jenkinsci/remoting/compare/d5db382f526c...5412f2864878

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/remoting/Callable.java src/main/java/hudson/remoting/Channel.java src/main/java/hudson/remoting/ChannelClosedException.java src/main/java/hudson/remoting/Request.java src/main/java/org/jenkinsci/remoting/ChannelStateException.java src/main/java/org/jenkinsci/remoting/protocol/impl/ChannelApplicationLayer.java http://jenkins-ci.org/commit/remoting/5412f2864878ea1ab96c8e58851e37d0638a6938 Log: Merge pull request #235 from oleg-nenashev/feature/ JENKINS-48133 _channelStateEx_diagnosability JENKINS-48133 - ChannelClosedException and ChannelStateException now record channel name and info when possible. Compare: https://github.com/jenkinsci/remoting/compare/d5db382f526c...5412f2864878
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/Launcher.java
          core/src/main/java/hudson/model/Computer.java
          core/src/main/java/hudson/slaves/ChannelPinger.java
          core/src/main/java/hudson/slaves/SlaveComputer.java
          core/src/main/java/jenkins/FilePathFilter.java
          core/src/main/java/jenkins/slaves/StandardOutputSwapper.java
          pom.xml
          test/src/test/java/hudson/bugs/JnlpAccessWithSecuredHudsonTest.java
          test/src/test/java/jenkins/security/Security218CliTest.java
          http://jenkins-ci.org/commit/jenkins/cb3990a4d6094260bea4571e7079fd0e3949047f
          Log:
          Update to Remoting 3.15 and Cleanup issues in Channel#current() usages (#3145)

          Pulls in fixes for: JENKINS-48133, JENKINS-48055, JENKINS-37566, JENKINS-48309, JENKINS-47965, JENKINS-48130, JENKINS-37670, JENKINS-37566, JENKINS-46724

          This change also adds some missing null/closing channel checks in the core.
          In some cases the change prevents spawning threads if the channel is in the invalid state.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/Launcher.java core/src/main/java/hudson/model/Computer.java core/src/main/java/hudson/slaves/ChannelPinger.java core/src/main/java/hudson/slaves/SlaveComputer.java core/src/main/java/jenkins/FilePathFilter.java core/src/main/java/jenkins/slaves/StandardOutputSwapper.java pom.xml test/src/test/java/hudson/bugs/JnlpAccessWithSecuredHudsonTest.java test/src/test/java/jenkins/security/Security218CliTest.java http://jenkins-ci.org/commit/jenkins/cb3990a4d6094260bea4571e7079fd0e3949047f Log: Update to Remoting 3.15 and Cleanup issues in Channel#current() usages (#3145) Pulls in fixes for: JENKINS-48133 , JENKINS-48055 , JENKINS-37566 , JENKINS-48309 , JENKINS-47965 , JENKINS-48130 , JENKINS-37670 , JENKINS-37566 , JENKINS-46724 This change also adds some missing null/closing channel checks in the core. In some cases the change prevents spawning threads if the channel is in the invalid state.
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          The change has been released in Remoting 3.15 and integrated towards Jenkins 2.98

          Show
          oleg_nenashev Oleg Nenashev added a comment - The change has been released in Remoting 3.15 and integrated towards Jenkins 2.98

            People

            • Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: