Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48169

Build results are not correctly migrated from old versions

    Details

    • Similar Issues:

      Description

      I upgraded the PostBuildScript from 0.17 to 1.1.0, and it completely messed things up for me. I ended up reverting, and rolling back the config changes.

      There are two problems:
      (1) The previous behavior was that the script ran on the agent. When you upgrade to 1.1.0, all your jobs get set to auto-run run on BOTH (master and agent). It should keep the previous behavior for existing jobs.
      (2) When you upgrade to 1.1.0, all your jobs get an additional configuration option added, which is when to run the step (SUCCESS, FAILED et)c. All existing jobs get upgraded with no condition selected. The result is that updating to 1.1.0 means none of my postbuildsteps run. When upgrading an existing job, it should preserve the existing behavior and run on all exit conditions.

      I don't know why you added the "run on SUCCESS/FAILURE" anyhow - it was already possible to do this using the Conditional BuildStep Plugin, which integrated well with PostBuildScript. Why add code to duplicate and existing function?

      Also, the Jenkins update center correctly tells me:

      Warning: the new version of this plugin claims to use a different settings format than the installed version ... Consult the plugin release notes for details

      However, there are no release notes with any detail.

      Sorry, I don't want to sound grumpy, and I appreciate that the plugin is getting some attention, but I think in this case insufficient attention was paid to the effect on existing users of the plugin.

      I think it would be best if 1.1.0 was withdrawn from distribution until the above can be addressed.

      Thanks
       

        Attachments

          Activity

          Hide
          tykeal Andrew Grimberg added a comment -

          I'm glad that it's finally seeing some fixes, especially since the last version (0.17) isn't even installable anymore from the plugin center but this is some serious breakage for folks that have been using it!

          Show
          tykeal Andrew Grimberg added a comment - I'm glad that it's finally seeing some fixes, especially since the last version (0.17) isn't even installable anymore from the plugin center but this is some serious breakage for folks that have been using it!
          Hide
          dheid Daniel Heid added a comment -

          Hi Matthew,

          thanks for your feedback. I hope you're not too disappointed. I'm new in maintaining Jenkins plugins and doing my best. This was my first release and I will be more careful in the future.

          1) Perhaps this is a misunderstanding: The setting only prevents scripts from being executed on specific node types. The previous version did not care about the node type. So both should be the correct mode.

          2) The additional option should be migrated. I added this, because the users wished to execute their postbuild scripts for other build results as well. I did never think about the conditional build step plugin. But now you have all in one.

          I thought, that the change log will be enough. But I will think about how to integrate some release notes.

          To not affect so many users, I will release a bugfixed version as soon as possible. I cannot remove old releases. Sorry for the problems!

          Regards

          Daniel

          Show
          dheid Daniel Heid added a comment - Hi Matthew, thanks for your feedback. I hope you're not too disappointed. I'm new in maintaining Jenkins plugins and doing my best. This was my first release and I will be more careful in the future. 1) Perhaps this is a misunderstanding: The setting only prevents scripts from being executed on specific node types. The previous version did not care about the node type. So both should be the correct mode. 2) The additional option should be migrated. I added this, because the users wished to execute their postbuild scripts for other build results as well. I did never think about the conditional build step plugin. But now you have all in one. I thought, that the change log will be enough. But I will think about how to integrate some release notes. To not affect so many users, I will release a bugfixed version as soon as possible. I cannot remove old releases. Sorry for the problems! Regards Daniel
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Heid
          Path:
          src/main/resources/lib/postbuildscript/role.jelly
          src/main/resources/lib/postbuildscript/role_de.properties
          http://jenkins-ci.org/commit/postbuildscript-plugin/759dcffcb145b897c81fa813e6f68ba1ec08b801
          Log:
          JENKINS-48169 Trying to use a better description for role limitation

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Heid Path: src/main/resources/lib/postbuildscript/role.jelly src/main/resources/lib/postbuildscript/role_de.properties http://jenkins-ci.org/commit/postbuildscript-plugin/759dcffcb145b897c81fa813e6f68ba1ec08b801 Log: JENKINS-48169 Trying to use a better description for role limitation
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Heid
          Path:
          README.md
          http://jenkins-ci.org/commit/postbuildscript-plugin/1cd74fcde9b3fb562bafdc21323f03bd28ba0c59
          Log:
          JENKINS-48169 Adapted README

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Heid Path: README.md http://jenkins-ci.org/commit/postbuildscript-plugin/1cd74fcde9b3fb562bafdc21323f03bd28ba0c59 Log: JENKINS-48169 Adapted README
          Hide
          dheid Daniel Heid added a comment -

          Sorry, but I cannot reproduce the bug by creating some jobs with build steps for "SUCCESS" or "FAIL" results. I attached a screenshot of my result:

          I also attached some example configurations for the old version (0.18) and the new one (1.1.1). 

          Everything looks good for me.

          What browser do you use? Which Jenkins version? Could you please upload a config.xml that allows me to reproduce the bug?

           

          Show
          dheid Daniel Heid added a comment - Sorry, but I cannot reproduce the bug by creating some jobs with build steps for "SUCCESS" or "FAIL" results. I attached a screenshot of my result: I also attached some example configurations for the old version (0.18) and the new one (1.1.1).  Everything looks good for me. What browser do you use? Which Jenkins version? Could you please upload a config.xml that allows me to reproduce the bug?  
          Hide
          dheid Daniel Heid added a comment -

          Okay, found the problem. It has the same cause as JENKINS-48197. Fixed it and will release a new version soon.

          Show
          dheid Daniel Heid added a comment - Okay, found the problem. It has the same cause as JENKINS-48197 . Fixed it and will release a new version soon.
          Hide
          mwebber Matthew Webber added a comment -

          Hi Daniel,

          Thanks for prompt fix; I appreciate the work you're doing on this

           I see that 1.1.1 has been released - I'll try it out (tomorrow I hope) in a test Jenkins, and see how it goes.

          Show
          mwebber Matthew Webber added a comment - Hi Daniel, Thanks for prompt fix; I appreciate the work you're doing on this  I see that 1.1.1 has been released - I'll try it out (tomorrow I hope) in a test Jenkins, and see how it goes.

            People

            • Assignee:
              dheid Daniel Heid
              Reporter:
              mwebber Matthew Webber
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: