Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48407

Permission issue after upgrade to 2.93

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Environment:
      OS: RHEL 6
      Jenkins: 2.93
      ThinBackup: 1.9
    • Similar Issues:

      Description

      After upgrading to Jenkins 2.93, ThinBackup sets the permissions of installedPlugins.xml to 600.  Previously, the permission were 644, matching the original file.

      If I watch the permissions as a backup is running, the permissions start as 644, but change to 600 by the time the backup completes.

      The dnusbaum user on IRC recommended I create this issue. 

      EDIT: This issue was discovered when automation attempts to copy the backups files off of the server as non jenkins user. I assume since the permissions of the backups are different than JENKINS_HOME, that restoring would fail. I have not had a chance to test this theory.

        Attachments

          Issue Links

            Activity

            Hide
            batmat Baptiste Mathus added a comment -

            Fixed towards upcoming 2.103 (if no out of order release has to happen in between). Cf. this commit to find out the actual release if needed.

            Show
            batmat Baptiste Mathus added a comment - Fixed towards upcoming 2.103 (if no out of order release has to happen in between). Cf. this commit  to find out the actual release if needed.
            Hide
            bharper b harper added a comment -

            I just upgraded to 2.103 and we are back in business. Thanks to all who helped fixed this issue.

            Show
            bharper b harper added a comment - I just upgraded to 2.103 and we are back in business. Thanks to all who helped fixed this issue.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/test/java/hudson/util/AtomicFileWriterTest.java
            http://jenkins-ci.org/commit/jenkins/631ed7a456fd8959c9399500db637edbaef77c9b
            Log:
            Merge pull request #3274 from batmat/JENKINS-48407-disable-test-temporarily

            Disable test temporarily to get the release out

            Compare: https://github.com/jenkinsci/jenkins/compare/66bb3dc6fd2a...631ed7a456fd

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/test/java/hudson/util/AtomicFileWriterTest.java http://jenkins-ci.org/commit/jenkins/631ed7a456fd8959c9399500db637edbaef77c9b Log: Merge pull request #3274 from batmat/ JENKINS-48407 -disable-test-temporarily Disable test temporarily to get the release out Compare: https://github.com/jenkinsci/jenkins/compare/66bb3dc6fd2a...631ed7a456fd
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Baptiste Mathus
            Path:
            core/src/test/java/hudson/util/AtomicFileWriterTest.java
            http://jenkins-ci.org/commit/jenkins/6cefcf17a8d92b43b738ec6cd5a2cf298cc1156e
            Log:
            JENKINS-48407 Re-enable AtomicFileWriterTest#checkPermissionsRespectUmask() (#3275)

            The previous test assumed permissions would always be the same,
            when they actually depend on umask settings.

            This change creates a file not using the temporary API, gets its
            permissions then compares it to the ones obtained using
            AtomicFileWriter.

            Note: we now only check the given permissions, not the "non-given".

            • Use assertThat(..., equalTo()) instead of a manual loop
            • Remove unused imports
            • Use TemporaryFolder instead of manual temporary dir creation
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Baptiste Mathus Path: core/src/test/java/hudson/util/AtomicFileWriterTest.java http://jenkins-ci.org/commit/jenkins/6cefcf17a8d92b43b738ec6cd5a2cf298cc1156e Log: JENKINS-48407 Re-enable AtomicFileWriterTest#checkPermissionsRespectUmask() (#3275) JENKINS-48407 Re-enable test The previous test assumed permissions would always be the same, when they actually depend on umask settings. This change creates a file not using the temporary API, gets its permissions then compares it to the ones obtained using AtomicFileWriter. Note: we now only check the given permissions, not the "non-given". Use assertThat(..., equalTo()) instead of a manual loop Remove unused imports Use TemporaryFolder instead of manual temporary dir creation
            Hide
            danielbeck Daniel Beck added a comment -

            This is in 2.105, so should be in the next LTS baseline even if we end up not going with 2.107.

            Show
            danielbeck Daniel Beck added a comment - This is in 2.105, so should be in the next LTS baseline even if we end up not going with 2.107.

              People

              • Assignee:
                batmat Baptiste Mathus
                Reporter:
                bharper b harper
              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: