Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49185

Thread-Safety: LastChanges Plugin shares SimpleDateFormat accross threads

    Details

    • Similar Issues:

      Description

      SimpleDateFormat class is not thread-safe, so it must not be used as a static field or as a local field used by multiple threads.

      Discovered it while investigating JENKINS-49176

        Attachments

          Issue Links

            Activity

            Show
            oleg_nenashev Oleg Nenashev added a comment - Created https://github.com/jenkinsci/last-changes-plugin/pull/41
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/com/github/jenkins/lastchanges/LastChangesPublisher.java
            src/main/java/com/github/jenkins/lastchanges/model/CommitInfo.java
            http://jenkins-ci.org/commit/last-changes-plugin/cf4f17f53d5b07f6db593fbc361acf3f20c6068a
            Log:
            [JENKINS-49176/JENKINS-49185] - Do not cache the SimpleDateFormat format (JEP-200 & concurrency)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/github/jenkins/lastchanges/LastChangesPublisher.java src/main/java/com/github/jenkins/lastchanges/model/CommitInfo.java http://jenkins-ci.org/commit/last-changes-plugin/cf4f17f53d5b07f6db593fbc361acf3f20c6068a Log: [JENKINS-49176/JENKINS-49185] - Do not cache the SimpleDateFormat format (JEP-200 & concurrency)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Rafael M. Pestano
            Path:
            Jenkinsfile
            pom.xml
            src/main/java/com/github/jenkins/lastchanges/LastChangesPublisher.java
            src/main/java/com/github/jenkins/lastchanges/model/CommitInfo.java
            http://jenkins-ci.org/commit/last-changes-plugin/8ea546001e39731785ff49585e486a7d27bd9557
            Log:
            Merge pull request #41 from oleg-nenashev/JENKINS-49176-jep-200

            [JENKINS-49176,JENKINS-49185] - Make the plugin compatible with Jenkins 2.102+ and fix concurrency issues

            Compare: https://github.com/jenkinsci/last-changes-plugin/compare/a3fa178233e3...8ea546001e39

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rafael M. Pestano Path: Jenkinsfile pom.xml src/main/java/com/github/jenkins/lastchanges/LastChangesPublisher.java src/main/java/com/github/jenkins/lastchanges/model/CommitInfo.java http://jenkins-ci.org/commit/last-changes-plugin/8ea546001e39731785ff49585e486a7d27bd9557 Log: Merge pull request #41 from oleg-nenashev/ JENKINS-49176 -jep-200 [JENKINS-49176,JENKINS-49185] - Make the plugin compatible with Jenkins 2.102+ and fix concurrency issues Compare: https://github.com/jenkinsci/last-changes-plugin/compare/a3fa178233e3...8ea546001e39
            Hide
            rmpestano Rafael Pestano added a comment - - edited

            Fixed for last-changes v2.6

            Show
            rmpestano Rafael Pestano added a comment - - edited Fixed for last-changes v2.6

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: