Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49210

Do not use ArrayList#sublist()

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Improved fix for JENKINS-49017.

      Using ArrayList#sublist() results java.util.RandomAccessSubList, which causes issues with JEP-200 and complicated output of xstream.

      Create a new ArrayList simply.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ikedam
            Path:
            pom.xml
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchQueueDecisionHandler.java
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchRunListener.java
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/510132ee60ed0e7ee5dc1083035dccc76ab0bcbc
            Log:
            JENKINS-49017JENKINS-49210 Allow to run tests against latest cores

            • This change allows us to run "mvn test -Djenkins.version=2.102 -Djava.level=8" to test compatibility with JEP-200
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: pom.xml src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchQueueDecisionHandler.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchRunListener.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/510132ee60ed0e7ee5dc1083035dccc76ab0bcbc Log: JENKINS-49017 JENKINS-49210 Allow to run tests against latest cores This change allows us to run "mvn test -Djenkins.version=2.102 -Djava.level=8" to test compatibility with JEP-200
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ikedam
            Path:
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProviderJenkinsTest.java
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/TextareaChoiceListProviderJenkinsTest.java
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/7c6a39bcf4069edeb71b9723052f0506135273cb
            Log:
            JENKINS-49017JENKINS-49210 Add tests to reproduce issues with JEP-200

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProviderJenkinsTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/TextareaChoiceListProviderJenkinsTest.java http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/7c6a39bcf4069edeb71b9723052f0506135273cb Log: JENKINS-49017 JENKINS-49210 Add tests to reproduce issues with JEP-200
            Show
            ikedam ikedam added a comment - https://github.com/jenkinsci/extensible-choice-parameter-plugin/pull/37
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/utility/TextareaStringListUtility.java
            src/main/resources/META-INF/hudson.remoting.ClassFilter
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest.java
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/config.xml
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jobs/JobWithSublist/config.xml
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jp.ikedam.jenkins.plugins.extensible_choice_parameter.GlobalTextareaChoiceListProvider.xml
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/afa9f3236d668a427cbcb8e504b32fc59af26dfb
            Log:
            [FIXED JENKINS-49210] JENKINS-49017 Do not use RandomAccessSubList

            • As fix for JEP-200.
            • Unfortunately I have to continue to allow RandomAccessSubList for configurations save with 1.4.2-.
            • To simplify xml.
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/utility/TextareaStringListUtility.java src/main/resources/META-INF/hudson.remoting.ClassFilter src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest.java src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/config.xml src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jobs/JobWithSublist/config.xml src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jp.ikedam.jenkins.plugins.extensible_choice_parameter.GlobalTextareaChoiceListProvider.xml http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/afa9f3236d668a427cbcb8e504b32fc59af26dfb Log: [FIXED JENKINS-49210] JENKINS-49017 Do not use RandomAccessSubList As fix for JEP-200. Unfortunately I have to continue to allow RandomAccessSubList for configurations save with 1.4.2-. To simplify xml.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/utility/TextareaStringListUtility.java
            src/main/resources/META-INF/hudson.remoting.ClassFilter
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest.java
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/config.xml
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jobs/JobWithSublist/config.xml
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jp.ikedam.jenkins.plugins.extensible_choice_parameter.GlobalTextareaChoiceListProvider.xml
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/c009a1c9b10071ca5457707491424f261dfbb4c6
            Log:
            Merge pull request #37 from ikedam/feature/JENKINS-49210_NoSublist

            JENKINS-49210 JENKINS-49017 Do not use RandomAccessSubList

            Compare: https://github.com/jenkinsci/extensible-choice-parameter-plugin/compare/584197ec252e...c009a1c9b100

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/utility/TextareaStringListUtility.java src/main/resources/META-INF/hudson.remoting.ClassFilter src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest.java src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/config.xml src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jobs/JobWithSublist/config.xml src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jp.ikedam.jenkins.plugins.extensible_choice_parameter.GlobalTextareaChoiceListProvider.xml http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/c009a1c9b10071ca5457707491424f261dfbb4c6 Log: Merge pull request #37 from ikedam/feature/ JENKINS-49210 _NoSublist JENKINS-49210 JENKINS-49017 Do not use RandomAccessSubList Compare: https://github.com/jenkinsci/extensible-choice-parameter-plugin/compare/584197ec252e...c009a1c9b100
            Hide
            ikedam ikedam added a comment -

            Released in extensible-choice-paramter-1.5.0

            Show
            ikedam ikedam added a comment - Released in extensible-choice-paramter-1.5.0

              People

              • Assignee:
                ikedam ikedam
                Reporter:
                ikedam ikedam
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: