Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49731

p4-plugin viewFilter unusable

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • p4-plugin
    • None
    • Jenkins 2.89.4
      p4-plugin 1.8.5

      Since 1.8.5, I'm getting IllegalArgumentException with viewFilter():

      checkout perforce(credential: 'anything', filter: [viewFilter('//depot/any/path')], ...)
      
      java.lang.IllegalArgumentException: Arguments to class org.jenkinsci.plugins.p4.filters.FilterPatternListImpl have to be explicitly named
      	at org.jenkinsci.plugins.structs.describable.DescribableModel.instantiate(DescribableModel.java:276)
      	at org.jenkinsci.plugins.structs.describable.UninstantiatedDescribable.instantiate(UninstantiatedDescribable.java:168)
      	at org.jenkinsci.plugins.structs.describable.DescribableModel.coerce(DescribableModel.java:394)
      	at org.jenkinsci.plugins.structs.describable.DescribableModel.coerceList(DescribableModel.java:485)
      	at org.jenkinsci.plugins.structs.describable.DescribableModel.coerce(DescribableModel.java:387)
      	at org.jenkinsci.plugins.structs.describable.DescribableModel.buildArguments(DescribableModel.java:340)
      	at org.jenkinsci.plugins.structs.describable.DescribableModel.instantiate(DescribableModel.java:281)
      Caused: java.lang.IllegalArgumentException: Could not instantiate {credential=anything, filter=[@viewFilter(<anonymous>=//depot/any/path)], ....[snip]

      I suppose it's related to @Symbol annotation in class FilterPatternListImpl.  This should be other than "viewFilter" in class FilterViewMaskImpl.

      https://github.com/jenkinsci/p4-plugin/blob/master/src/main/java/org/jenkinsci/plugins/p4/filters/FilterPatternListImpl.java#L63

       

            Unassigned Unassigned
            yaegashi Takeshi Yaegashi
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: