Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50407

NPE from SandboxContinuable.run0 after restart

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      In this build I observed

      ...
      Running in Durability level: PERFORMANCE_OPTIMIZED
      ...
      Resuming build at ... after Jenkins restart
      [Pipeline] End of Pipeline
      
      GitHub has been notified of this commit's build result
      
      java.lang.NullPointerException
      	at org.jenkinsci.plugins.workflow.cps.SandboxContinuable.run0(SandboxContinuable.java:43)
      	at org.jenkinsci.plugins.workflow.cps.CpsThread.runNextChunk(CpsThread.java:174)
      	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:331)
      	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$200(CpsThreadGroup.java:82)
      	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:243)
      	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:231)
      	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:64)
      	at ...
      Finished: FAILURE
      

      The flow graph is also missing. Not sure what happened here.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            Sam Van Oort claimed a possible link to a couple of other bugs under investigation.

            Show
            jglick Jesse Glick added a comment - Sam Van Oort claimed a possible link to a couple of other bugs under investigation.
            Hide
            svanoort Sam Van Oort added a comment -

            I'll upgrade that from "possible" to guaranteed, knowing that the flow graph is missing too. That's a pipeline that was not cleanly persisted in performance optimized mode – and yet it is trying to resume (when it should be forbidden).

            I'm armor-plating all the resumption & completion-state logic just to try to make this a bit more failsafe.

            Show
            svanoort Sam Van Oort added a comment - I'll upgrade that from "possible" to guaranteed, knowing that the flow graph is missing too. That's a pipeline that was not cleanly persisted in performance optimized mode – and yet it is trying to resume (when it should be forbidden). I'm armor-plating all the resumption & completion-state logic just to try to make this a bit more failsafe.
            Hide
            jglick Jesse Glick added a comment -

            In Review perhaps?

            Show
            jglick Jesse Glick added a comment - In Review perhaps?
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Sam Van Oort
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
            src/test/java/org/jenkinsci/plugins/workflow/job/WorkflowRunRestartTest.java
            src/test/java/org/jenkinsci/plugins/workflow/job/WorkflowRunTest.java
            http://jenkins-ci.org/commit/workflow-job-plugin/f0c26058f31d4f159a82a3cace52935e93f20701
            Log:
            Merge pull request #93 from svanoort/fix-resume-issues

            Fix resume issues JENKINS-49686 and JENKINS-50199 and JENKINS-50407

            Compare: https://github.com/jenkinsci/workflow-job-plugin/compare/e11cea623f61...f0c26058f31d

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java src/test/java/org/jenkinsci/plugins/workflow/job/WorkflowRunRestartTest.java src/test/java/org/jenkinsci/plugins/workflow/job/WorkflowRunTest.java http://jenkins-ci.org/commit/workflow-job-plugin/f0c26058f31d4f159a82a3cace52935e93f20701 Log: Merge pull request #93 from svanoort/fix-resume-issues Fix resume issues JENKINS-49686 and JENKINS-50199 and JENKINS-50407 Compare: https://github.com/jenkinsci/workflow-job-plugin/compare/e11cea623f61...f0c26058f31d
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/cps/SandboxContinuable.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/5d08569babf0249ddd3b0723bcf5671df1e48ac7
            Log:
            JENKINS-50407 Trying to diagnose an NPE.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/workflow/cps/SandboxContinuable.java http://jenkins-ci.org/commit/workflow-cps-plugin/5d08569babf0249ddd3b0723bcf5671df1e48ac7 Log: JENKINS-50407 Trying to diagnose an NPE.
            Hide
            svanoort Sam Van Oort added a comment -

            Resolved as of workflow-cps 2.47 and workflow-job 2.18

            Show
            svanoort Sam Van Oort added a comment - Resolved as of workflow-cps 2.47 and workflow-job 2.18

              People

              • Assignee:
                svanoort Sam Van Oort
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: