Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50412

Fingerprints logs should be less verbose

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Fingerprint log files can grow large, mostly composed of a single, repeated line that provides little to no value, like this:

       

      possibly trimming /var/jenkins_home/fingerprints/[...]

      I propose we eliminate this line, to keep the log from growing so large and filling up with useless lines.

       

      This issue is also noted as an aside in a comment on JENKINS-19066.

       

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jeff Thompson
            Path:
            core/src/main/java/hudson/model/FingerprintCleanupThread.java
            core/src/test/java/hudson/model/FingerprintCleanupThreadTest.java
            http://jenkins-ci.org/commit/jenkins/a9eafdb973d0e9697e2f7a8a3f4e3441464398f4
            Log:
            JENKINS-50412 Fingerprints logs should be less verbose (#3373)

            Eliminate the logging line that says
            possibly trimming /var/jenkins_home/fingerprints/[...]
            This line fills up the fingerprints log file with repetitive, useless information.
            The operation it calls provides its own logging that can be turned on if detailed
            logging is actually needed instead of running this one repeatedly.

            Also, while in the area, convert a couple of FileFilter inner classes to lambdas
            and inline them. This reduces unnecessary boilerplate and improves clarity.

            In order to make this change testable, I elected to remove the final restriction on the
            class and annotate the class as restricted. This allows me to create unit tests for
            this change and also verify existing capability at the appropriate level.

            • Watch out for varying line endings.

            Use a reliable check.

            • Correct a few minor issues caught in review.
            • Change to correct access modifier.

            *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

            Functionality will be removed from GitHub.com on January 31st, 2019.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jeff Thompson Path: core/src/main/java/hudson/model/FingerprintCleanupThread.java core/src/test/java/hudson/model/FingerprintCleanupThreadTest.java http://jenkins-ci.org/commit/jenkins/a9eafdb973d0e9697e2f7a8a3f4e3441464398f4 Log: JENKINS-50412 Fingerprints logs should be less verbose (#3373) JENKINS-50412 - Fingerprints logs should be less verbose Eliminate the logging line that says possibly trimming /var/jenkins_home/fingerprints/ [...] This line fills up the fingerprints log file with repetitive, useless information. The operation it calls provides its own logging that can be turned on if detailed logging is actually needed instead of running this one repeatedly. Also, while in the area, convert a couple of FileFilter inner classes to lambdas and inline them. This reduces unnecessary boilerplate and improves clarity. In order to make this change testable, I elected to remove the final restriction on the class and annotate the class as restricted. This allows me to create unit tests for this change and also verify existing capability at the appropriate level. Watch out for varying line endings. Use a reliable check. Correct a few minor issues caught in review. Change to correct access modifier. * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
            Hide
            dnusbaum Devin Nusbaum added a comment -

            Fixed in Jenkins 2.120.

            Show
            dnusbaum Devin Nusbaum added a comment - Fixed in Jenkins 2.120 .

              People

              • Assignee:
                jthompson Jeff Thompson
                Reporter:
                jthompson Jeff Thompson
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: