Details

    • Similar Issues:

      Description

      Since we do not want to trust agent JVMs with S3 credentials, all BlobCallable implementations should be given a set of presigned URLs for PUT method and not use S3 code at all.

        Attachments

          Activity

          Show
          csanchez Carlos Sanchez added a comment - In review at  https://github.com/jenkinsci/artifact-manager-s3-plugin/pull/4
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Carlos Sanchez
          Path:
          src/main/java/io/jenkins/plugins/artifact_manager_s3/JCloudsApiExtensionPoint.java
          src/main/java/io/jenkins/plugins/artifact_manager_s3/JCloudsArtifactManager.java
          src/main/java/io/jenkins/plugins/artifact_manager_s3/JCloudsBlobStore.java
          src/main/java/io/jenkins/plugins/artifact_manager_s3/S3BlobStore.java
          src/test/java/io/jenkins/plugins/artifact_manager_s3/JCloudsArtifactManagerTest.java
          src/test/java/io/jenkins/plugins/artifact_manager_s3/JCloudsBlobStoreTest.java
          http://jenkins-ci.org/commit/artifact-manager-s3-plugin/dd6080ff39896beaadd6d1ea9d0f3f14dd450fe9
          Log:
          Merge pull request #4 from jenkinsci/presigned-url

          JENKINS-50518 Only run upload/download in the agent

          Compare: https://github.com/jenkinsci/artifact-manager-s3-plugin/compare/014bd2456927...dd6080ff3989

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Carlos Sanchez Path: src/main/java/io/jenkins/plugins/artifact_manager_s3/JCloudsApiExtensionPoint.java src/main/java/io/jenkins/plugins/artifact_manager_s3/JCloudsArtifactManager.java src/main/java/io/jenkins/plugins/artifact_manager_s3/JCloudsBlobStore.java src/main/java/io/jenkins/plugins/artifact_manager_s3/S3BlobStore.java src/test/java/io/jenkins/plugins/artifact_manager_s3/JCloudsArtifactManagerTest.java src/test/java/io/jenkins/plugins/artifact_manager_s3/JCloudsBlobStoreTest.java http://jenkins-ci.org/commit/artifact-manager-s3-plugin/dd6080ff39896beaadd6d1ea9d0f3f14dd450fe9 Log: Merge pull request #4 from jenkinsci/presigned-url JENKINS-50518 Only run upload/download in the agent Compare: https://github.com/jenkinsci/artifact-manager-s3-plugin/compare/014bd2456927...dd6080ff3989
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml http://jenkins-ci.org/commit/artifact-manager-s3-plugin/8c62ca6a7efb07c3718f218adb33b0aa11c0e244 Log: JENKINS-50518 Picking up https://github.com/jenkinsci/workflow-api-plugin/pull/67/commits/915f652453f8199069459ad733193e30492d96e6 and https://github.com/jenkinsci/docker-fixtures/pull/19 to run tests inside Dockerized agents.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Carlos Sanchez
          Path:
          pom.xml
          src/test/java/io/jenkins/plugins/artifact_manager_s3/JCloudsAbstractTest.java
          src/test/java/io/jenkins/plugins/artifact_manager_s3/JCloudsArtifactManagerTest.java
          http://jenkins-ci.org/commit/artifact-manager-s3-plugin/fb9698c455b46c03abaf6f2f88dcb832f0e4bccc
          Log:
          Merge pull request #7 from jenkinsci/docker-JENKINS-50518

          JENKINS-50518 Run tests inside Dockerized agents

          Compare: https://github.com/jenkinsci/artifact-manager-s3-plugin/compare/23cd4398c949...fb9698c455b4

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Carlos Sanchez Path: pom.xml src/test/java/io/jenkins/plugins/artifact_manager_s3/JCloudsAbstractTest.java src/test/java/io/jenkins/plugins/artifact_manager_s3/JCloudsArtifactManagerTest.java http://jenkins-ci.org/commit/artifact-manager-s3-plugin/fb9698c455b46c03abaf6f2f88dcb832f0e4bccc Log: Merge pull request #7 from jenkinsci/docker- JENKINS-50518 JENKINS-50518 Run tests inside Dockerized agents Compare: https://github.com/jenkinsci/artifact-manager-s3-plugin/compare/23cd4398c949...fb9698c455b4

            People

            • Assignee:
              csanchez Carlos Sanchez
              Reporter:
              jglick Jesse Glick
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: