Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50670

Pipeline job does not fail when serialization of Pipeline steps arguments fails within NonCPS

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Discovered it during testing of JENKINS-50665

      Example (for nonCPS wrapper which may not work correctly as Jesse Glick mentioned in the PR):

      nonCPS.exec() { 
          def formatter = new org.jfree.chart.axis.QuarterDateFormat()
          printTimestamp arg1: 'foo', formatter: formatter, persistFormatter: true
      }
      

        Attachments

          Issue Links

            Activity

            Hide
            oleg_nenashev Oleg Nenashev added a comment -
            Show
            oleg_nenashev Oleg Nenashev added a comment - Reproduced the issue in https://github.com/jenkinsci/workflow-cps-plugin/pull/218 (autotest)
            Hide
            jglick Jesse Glick added a comment -

            As designed I think. ArgumentsAction represents a best effort at recording metadata. If something cannot be recorded, so be it—the program continues and metadata is incomplete.

            Show
            jglick Jesse Glick added a comment - As designed I think. ArgumentsAction represents a best effort at recording metadata. If something cannot be recorded, so be it—the program continues and metadata is incomplete.
            Hide
            svanoort Sam Van Oort added a comment -

            Yes, as designed. ArgumentAction data is considered 'noncritical.'

            Show
            svanoort Sam Van Oort added a comment - Yes, as designed. ArgumentAction data is considered 'noncritical.'
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            OK, I will invert the test in the pull request then

            Show
            oleg_nenashev Oleg Nenashev added a comment - OK, I will invert the test in the pull request then
            Hide
            svanoort Sam Van Oort added a comment -

            I created JENKINS-50752 to track the fact that we're not successfully bulletproofing against unserializable Action contents.

            Show
            svanoort Sam Van Oort added a comment - I created JENKINS-50752 to track the fact that we're not successfully bulletproofing against unserializable Action contents.
            Hide
            svanoort Sam Van Oort added a comment -

            Oleg Nenashev the actual argument data is being bulletproofed by JENKINS-50752 implementation now so it CANNOT cause failures elsewhere if it can't be persisted and is instead discarded.

            Show
            svanoort Sam Van Oort added a comment - Oleg Nenashev the actual argument data is being bulletproofed by JENKINS-50752 implementation now so it CANNOT cause failures elsewhere if it can't be persisted and is instead discarded.

              People

              • Assignee:
                Unassigned
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: