Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50965

Malformed log message

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Trivial
    • Resolution: Fixed
    • Component/s: remoting
    • Environment:
      System property hudson.remoting.RemoteClassLoader.force is set to the name of a class to be loaded, e.g. -Dhudson.remoting.RemoteClassLoader.force=com.sun.jna.Native
    • Similar Issues:

      Description

      JENKINS-19445 added a workaround for a Windows JNA deadlock bug in pr#82. That added a log message.
      Unfortunately that log message was malformed (using %s instead of {0} etc), resulting in an ugly and unhelpful log message saying:
      INFO: %s class '%s' using classloader: %s

      It should say something like:
      INFO: Loaded class 'com.foo.Bar' using classloader: com.foo.SomeClassLoader
      instead.

        Attachments

          Activity

          Show
          pjdarton pjdarton added a comment - See https://github.com/jenkinsci/remoting/pull/267  
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Peter Darton
          Path:
          src/main/java/hudson/remoting/UserRequest.java
          http://jenkins-ci.org/commit/remoting/3cc5305ac33a4a7e19ca053ae1dbf85163e0e2a5
          Log:
          JENKINS-50965 - Fix log message (#267)

          Current code logs "INFO: %s class '%s' using classloader: %s" if system
          property hudson.remoting.RemoteClassLoader.force is set.
          The code should be using java.text.MessageFormat.format syntax
          but is mistakenly using String.format syntax instead.

          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Peter Darton Path: src/main/java/hudson/remoting/UserRequest.java http://jenkins-ci.org/commit/remoting/3cc5305ac33a4a7e19ca053ae1dbf85163e0e2a5 Log: JENKINS-50965 - Fix log message (#267) Current code logs "INFO: %s class '%s' using classloader: %s" if system property hudson.remoting.RemoteClassLoader.force is set. The code should be using java.text.MessageFormat.format syntax but is mistakenly using String.format syntax instead. * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/slaves/SlaveComputer.java
          pom.xml
          http://jenkins-ci.org/commit/jenkins/c405ae701c4bca18f7b4edc6e5cd3bc053b7ee60
          Log:
          [JENKINS-51541,JENKINS-51551,...] - Remoting 3.21 + Allow passing custom CommandTransport implementations to SlaveComputer from ComputerLauncher (#3455)

          • JENKINS-51541 - Introduce new SlaveComputer#setChannel() method which takes custom ChannelBuilder and CommandTransport
          • JENKINS-51541 - Listener is nullable according to the documentation
          • [JENKINS-51551,JENKINS-51223,JENKINS-50965] - Update Remoting to 3.21
          • JENKINS-51541 - Restrict SlaveComputer#setChannel(ChannelBuilder cb, …) to Beta-use only

          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/slaves/SlaveComputer.java pom.xml http://jenkins-ci.org/commit/jenkins/c405ae701c4bca18f7b4edc6e5cd3bc053b7ee60 Log: [JENKINS-51541,JENKINS-51551,...] - Remoting 3.21 + Allow passing custom CommandTransport implementations to SlaveComputer from ComputerLauncher (#3455) JENKINS-51541 - Introduce new SlaveComputer#setChannel() method which takes custom ChannelBuilder and CommandTransport JENKINS-51551 - Pick Remoting version with the API patch JENKINS-51541 - Listener is nullable according to the documentation [JENKINS-51551,JENKINS-51223,JENKINS-50965] - Update Remoting to 3.21 JENKINS-51541 - Restrict SlaveComputer#setChannel(ChannelBuilder cb, …) to Beta-use only * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Fixed in Remoting 3.21 and Jenkins 2.127

          Show
          oleg_nenashev Oleg Nenashev added a comment - Fixed in Remoting 3.21 and Jenkins 2.127

            People

            • Assignee:
              jthompson Jeff Thompson
              Reporter:
              pjdarton pjdarton
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: