Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51397

docker login being called without server-related environment variables

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Split out from JENKINS-38018. The environment variables set by withDockerServer are not being passed to the docker login command.

        Attachments

          Issue Links

            Activity

            Hide
            schulzha Hans Schulz added a comment -

            Jesse Glick The fix works for us, thank you!

            Show
            schulzha Hans Schulz added a comment - Jesse Glick The fix works for us, thank you!
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerRegistryEndpoint.java
            src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerRegistryToken.java
            src/main/java/org/jenkinsci/plugins/docker/commons/impl/RegistryKeyMaterialFactory.java
            src/test/java/org/jenkinsci/plugins/docker/commons/util/SampleDockerBuilder.java
            http://jenkins-ci.org/commit/docker-commons-plugin/4f7f7772d36c277c0a055489d35bccaa3658890e
            Log:
            JENKINS-51397 Define API for passing environment to docker login command.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerRegistryEndpoint.java src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerRegistryToken.java src/main/java/org/jenkinsci/plugins/docker/commons/impl/RegistryKeyMaterialFactory.java src/test/java/org/jenkinsci/plugins/docker/commons/util/SampleDockerBuilder.java http://jenkins-ci.org/commit/docker-commons-plugin/4f7f7772d36c277c0a055489d35bccaa3658890e Log: JENKINS-51397 Define API for passing environment to docker login command.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerRegistryEndpoint.java
            src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerRegistryToken.java
            src/main/java/org/jenkinsci/plugins/docker/commons/impl/RegistryKeyMaterialFactory.java
            src/test/java/org/jenkinsci/plugins/docker/commons/util/SampleDockerBuilder.java
            http://jenkins-ci.org/commit/docker-commons-plugin/a5e6fa06a9d2f2419dc4e9cf1c07ff2886df5a5e
            Log:
            Merge pull request #71 from jglick/docker-login-env-JENKINS-51397

            JENKINS-51397 Define API for passing environment to docker login command

            Compare: https://github.com/jenkinsci/docker-commons-plugin/compare/5bd5ad32f534...a5e6fa06a9d2
            *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

            Functionality will be removed from GitHub.com on January 31st, 2019.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerRegistryEndpoint.java src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerRegistryToken.java src/main/java/org/jenkinsci/plugins/docker/commons/impl/RegistryKeyMaterialFactory.java src/test/java/org/jenkinsci/plugins/docker/commons/util/SampleDockerBuilder.java http://jenkins-ci.org/commit/docker-commons-plugin/a5e6fa06a9d2f2419dc4e9cf1c07ff2886df5a5e Log: Merge pull request #71 from jglick/docker-login-env- JENKINS-51397 JENKINS-51397 Define API for passing environment to docker login command Compare: https://github.com/jenkinsci/docker-commons-plugin/compare/5bd5ad32f534...a5e6fa06a9d2 * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStep.java
            http://jenkins-ci.org/commit/docker-workflow-plugin/2319da7e180d2c49d77f8572becb980573bdf241
            Log:
            JENKINS-51397 Pass environment to docker login command.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStep.java http://jenkins-ci.org/commit/docker-workflow-plugin/2319da7e180d2c49d77f8572becb980573bdf241 Log: JENKINS-51397 Pass environment to docker login command.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStep.java
            http://jenkins-ci.org/commit/docker-workflow-plugin/a19719c196def05b740b44b75376e25dda077b84
            Log:
            Merge pull request #140 from jglick/docker-login-env-JENKINS-51397

            JENKINS-51397 Pass environment to docker login command

            Compare: https://github.com/jenkinsci/docker-workflow-plugin/compare/e8a1815cf41b...a19719c196de
            *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

            Functionality will be removed from GitHub.com on January 31st, 2019.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStep.java http://jenkins-ci.org/commit/docker-workflow-plugin/a19719c196def05b740b44b75376e25dda077b84 Log: Merge pull request #140 from jglick/docker-login-env- JENKINS-51397 JENKINS-51397 Pass environment to docker login command Compare: https://github.com/jenkinsci/docker-workflow-plugin/compare/e8a1815cf41b...a19719c196de * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                2 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: