Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-52281

Clean up some deprecated stuff in PipelineNodeTest

    Details

    • Similar Issues:

      Description

      Summary
      There are a lot of deprecated things in this test class. In an effort to help stop occasional test flakes in PCT, I'll fix some of that.

      Details

      • Update the calls to new CpsFlowDefinition, like the one shown here. CpsFlowDefinition is expecting a second argument, a boolean, and most of the calls to it in this test don't have it. I'll change the constructor calls to use the current one.
      • Update much (but probably not all) of the sample pipeline code being used in this test, so that it has block-scoped stages. Without which, you'll see a lot of messages like this in your logs:
        [Pipeline] {
        [Pipeline] stage (hey)
        Using the ‘stage’ step without a block argument is deprecated
        

        Attachments

          Activity

          Hide
          kshultz Karl Shultz added a comment -

          I didn't update all the sample pipeline code. That tends to change the flow graph of a pipeline pretty significantly, and I was breaking a lot of the Assert tests that were looking for particular numbers. Maybe some other time.

          Show
          kshultz Karl Shultz added a comment - I didn't update all the sample pipeline code. That tends to change the flow graph of a pipeline pretty significantly, and I was breaking a lot of the Assert tests that were looking for particular numbers. Maybe some other time.
          Hide
          kshultz Karl Shultz added a comment -
          Show
          kshultz Karl Shultz added a comment - PR up .
          Hide
          kshultz Karl Shultz added a comment -

          Merged 1764.

          Show
          kshultz Karl Shultz added a comment - Merged 1764 .

            People

            • Assignee:
              kshultz Karl Shultz
              Reporter:
              kshultz Karl Shultz
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: