Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-53503

More test coverage for Snapshotter.git()

    XMLWordPrintable

    Details

    • Sprint:
      Evergreen - Milestone 2
    • Similar Issues:

      Description

      Problem statement

      The Evergreen-client class snapshotter.js is tested indirectly, we should test the core git() function more directly and this is the core and most critical part of this class.

      Expected behavior

      Acceptance criterion: the code coverage should be higher.

      To check/get started on this,

      This will generate a coverage directory, open coverage/lcov-report/index.html with your browser to see the coverage obtained.
      Make it better, rinse, repeat .

        Attachments

          Activity

          Hide
          rtyler R. Tyler Croy added a comment -

          I was most interested in testing some of the error branches in git() fwi

          Show
          rtyler R. Tyler Croy added a comment - I was most interested in testing some of the error branches in git() fwi
          Hide
          ales Ales Blaze added a comment -

          But where to get started? 

          As being a new person here, interested in contributing and improving this stuff, but wait I don't know where to go?

           

          I don't know where to get the files , please navigate me.

          Show
          ales Ales Blaze added a comment - But where to get started?  As being a new person here, interested in contributing and improving this stuff, but wait I don't know where to go?   I don't know where to get the files , please navigate me.
          Hide
          batmat Baptiste Mathus added a comment -

          Ales Blaze starting point is https://github.com/jenkins-infra/evergreen

          Then this issue is about adding coverage to the https://github.com/jenkins-infra/evergreen/blob/master/distribution/client/src/lib/snapshotter.ts class.

          To run tests and coverage on this, clone the repo, then cd to distribution/client, then run make check. That should be a good starting point.

          Please come over to our chat at https://gitter.im/jenkins-infra/evergreen to get live help if needed. I'm willing to add docs to help people hack on Evergreen, but as we can't document everything, I need to understand what are the biggest pains.

          Also, going to rephrase the issue description here a bit so that it's a bit more complete for outsiders.

          Thanks

          Show
          batmat Baptiste Mathus added a comment - Ales Blaze starting point is https://github.com/jenkins-infra/evergreen Then this issue is about adding coverage to the https://github.com/jenkins-infra/evergreen/blob/master/distribution/client/src/lib/snapshotter.ts class. To run tests and coverage on this, clone the repo, then cd to distribution/client, then run make check . That should be a good starting point. Please come over to our chat at https://gitter.im/jenkins-infra/evergreen to get live help if needed. I'm willing to add docs to help people hack on Evergreen, but as we can't document everything, I need to understand what are the biggest pains. Also, going to rephrase the issue description here a bit so that it's a bit more complete for outsiders. Thanks

            People

            • Assignee:
              Unassigned
              Reporter:
              batmat Baptiste Mathus
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: