Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-53608

Fix up incorrect method signatures on readResolve

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      readResolve() should be ANY_ACCESS_MODIFIER Object readResolve() however there are a few uses in class where this is not the case.

      These should be tidied up and fixed.

      hudson/triggers/SCMTrigger.java:        private void readResolve() {
      jenkins/security/apitoken/ApiTokenStats.java:    private ApiTokenStats readResolve() {
      jenkins/security/apitoken/ApiTokenStats.java:        private SingleTokenStats readResolve() {
      

        Attachments

          Issue Links

            Activity

            Hide
            olivergondza Oliver Gondža added a comment -

            I am hesitant to backport this as it does not address any customer issue while being potentially risky.

            Show
            olivergondza Oliver Gondža added a comment - I am hesitant to backport this as it does not address any customer issue while being potentially risky.
            Hide
            teilo James Nord added a comment -

            Daniel Beck requested the backport. I as the reporter personally have no need of one. The only thing I can think may be impacted is if a user has set 1000000 as the SCM threads and that the `readResolve` does not kick in there to limit it to {{MAX_SCM_THREAD}}s.  But that can be fixed without a code change if the user hits the issue (that may not even be an issue)

            Show
            teilo James Nord added a comment - Daniel Beck requested the backport. I as the reporter personally have no need of one. The only thing I can think may be impacted is if a user has set 1000000 as the SCM threads and that the ` readResolve ` does not kick in there to limit it to {{MAX_SCM_THREAD}}s.  But that can be fixed without a code change if the user hits the issue (that may not even be an issue)
            Hide
            danielbeck Daniel Beck added a comment -

            Agreed.

            Show
            danielbeck Daniel Beck added a comment - Agreed.

              People

              • Assignee:
                teilo James Nord
                Reporter:
                teilo James Nord
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: