Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55205

Review findbugs error with some OS+JDK

    Details

    • Similar Issues:
    • Released As:
      saml-1.1.2

      Description

      After this PR findbugs claim for some attention

      [INFO] org.jenkinsci.plugins.saml.BundleKeyStore.saveKeyStore(File, KeyStore, String) may fail to clean up java.io.OutputStream [org.jenkinsci.plugins.saml.BundleKeyStore, org.jenkinsci.plugins.saml.BundleKeyStore, org.jenkinsci.plugins.saml.BundleKeyStore, org.jenkinsci.plugins.saml.BundleKeyStore, org.jenkinsci.plugins.saml.BundleKeyStore] Obligation to clean up resource created at BundleKeyStore.java:[line 184] is not dischargedPath continues at BundleKeyStore.java:[line 186]Path continues at BundleKeyStore.java:[line 188]Path continues at BundleKeyStore.java:[line 189]Path continues at BundleKeyStore.java:[line 190] OBL_UNSATISFIED_OBLIGATION
      
      [INFO] The field org.jenkinsci.plugins.saml.SamlAuthenticationToken.session is transient but isn't set by deserialization [org.jenkinsci.plugins.saml.SamlAuthenticationToken] In SamlAuthenticationToken.java SE_TRANSIENT_FIELD_NOT_RESTORED
      
      [INFO] Nullcheck of in at line 30 of value previously dereferenced in org.jenkinsci.plugins.saml.SamlValidateIdPMetadata.process() [org.jenkinsci.plugins.saml.SamlValidateIdPMetadata, org.jenkinsci.plugins.saml.SamlValidateIdPMetadata] At SamlValidateIdPMetadata.java:[line 30]Redundant null check at SamlValidateIdPMetadata.java:[line 38] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
      
      [INFO] 
      

        Attachments

          Issue Links

            Activity

            Hide
            ifernandezcalvo Ivan Fernandez Calvo added a comment -

            there are some error reported by findbugs on Java 11 that are false positive due https://issues.jenkins-ci.org/browse/JENKINS-53692, I will ignore them

            Show
            ifernandezcalvo Ivan Fernandez Calvo added a comment - there are some error reported by findbugs on Java 11 that are false positive due https://issues.jenkins-ci.org/browse/JENKINS-53692 , I will ignore them
            Hide
            batmat Baptiste Mathus added a comment -

            Hello Ivan Fernandez Calvo, about that, you might also be interested to watch https://github.com/jenkinsci/plugin-pom/pull/128

            Show
            batmat Baptiste Mathus added a comment - Hello Ivan Fernandez Calvo , about that, you might also be interested to watch https://github.com/jenkinsci/plugin-pom/pull/128

              People

              • Assignee:
                ifernandezcalvo Ivan Fernandez Calvo
                Reporter:
                ifernandezcalvo Ivan Fernandez Calvo
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: