Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55787

Switch labels from entry to checkbox

    Details

    • Similar Issues:
    • Released As:
      Jenkins 2.179

      Description

      This is the preferred style:


      As opposed to:


      or

       

      I'm going to point to this issue for a bunch of plugins.

       

      Note: my initial efforts relied on using optionalBlock instead of entry + checkbox. Unfortunately this interacts poorly w/ the form submission magic, and so rather than continue down that path, I'm switching to moving label's from the entry to the checkbox. The rendering won't generally change from the examples above.

       

      Please don't close this ticket when an individual PR is merged, I'm using the same ticket for many plugins.

        Attachments

          Issue Links

            Activity

            Hide
            kinow Bruno P. Kinoshita added a comment -

            Sorry Josh Soref! I am so used to add the link to the release notes in the Wiki, move to released, and close... then after a few minutes I realized it was not a tap-plugin issue, nor assigned to me.

            I apologize. Re-opened.

            Show
            kinow Bruno P. Kinoshita added a comment - Sorry Josh Soref ! I am so used to add the link to the release notes in the Wiki, move to released, and close... then after a few minutes I realized it was not a tap-plugin issue, nor assigned to me. I apologize. Re-opened.
            Hide
            jsoref Josh Soref added a comment -

            I'm not used to using this JIRA either.

            Since this JIRA allows selecting multiple components, it made sense to use a single ticket for all the instances, so I'm trying to take advantage of that feature.

            Show
            jsoref Josh Soref added a comment - I'm not used to using this JIRA either. Since this JIRA allows selecting multiple components, it made sense to use a single ticket for all the instances, so I'm trying to take advantage of that feature.
            Hide
            alecharp Adrien Lecharpentier added a comment -

            Thank you Josh Soref! I'm speaking about mailer-plugin, as you filled a PR on this plugin. I've attached the screenshots in the PR you opened to see the diff.

            Even if I agree with you that we should have the checkbox before the label, the fact that all Jenkins configurations are structured like a table (with the left column the label and the right column for the field), I fear that changing this might cause some incomprehension.

            Show
            alecharp Adrien Lecharpentier added a comment - Thank you Josh Soref ! I'm speaking about mailer-plugin , as you filled a PR on this plugin. I've attached the screenshots in the PR you opened to see the diff. Even if I agree with you that we should have the checkbox before the label, the fact that all Jenkins configurations are structured like a table  (with the left column the label and the right column for the field), I fear that changing this might cause some incomprehension.
            Hide
            jsoref Josh Soref added a comment -

            Adrien Lecharpentier: once this change is mostly done, JENKINS-56109 / jenkinsci/jenkins#3895 will change the layout away from tables. Note: I'm currently taking a short hiatus from jenkins.

            Show
            jsoref Josh Soref added a comment - Adrien Lecharpentier : once this change is mostly done,  JENKINS-56109  /  jenkinsci/jenkins#3895  will change the layout away from tables. Note: I'm currently taking a short hiatus from jenkins.
            Hide
            felfert Fritz Elfert added a comment - - edited

            Why is the state of this ticked resolved(fixed) ?
            IMO, it should be set to resolved, once all plugins have the PRs merged, and for the jclouds-plugin, I can say the PR is incomplete: You missed 10 more checkboxes. Therefore; not (yet) merged!

            Show
            felfert Fritz Elfert added a comment - - edited Why is the state of this ticked resolved(fixed) ? IMO, it should be set to resolved, once all plugins have the PRs merged, and for the jclouds-plugin, I can say the PR is incomplete: You missed 10 more checkboxes. Therefore; not (yet) merged!
            Hide
            felfert Fritz Elfert added a comment -
            Show
            felfert Fritz Elfert added a comment - https://github.com/jenkinsci/jclouds-plugin/pull/132 has been merged.
            Hide
            d_garry Igor Rondarev added a comment - - edited

            Josh, i'm terrbily sorry, but don't you think that this decision is a bit premature? I agree with Adrien that currently all job parameters looks like a table that's easy to watch and use, and 'jumping' to the right side at boolean parameters is, to be honest, not very easy to read (also from the same UX point of view, we get empty gap at the left side where label originally was; i've even created a bug report (JENKINS-59388) and have rewritten several jobs in our organization from 'booleanParam' to 'choice' with 'true'/'false' values before i found this ticket). Probably it would be better to make it configurable or add another type (e.g. BooleanLabel) with UI you propose.

            Show
            d_garry Igor Rondarev added a comment - - edited Josh, i'm terrbily sorry, but don't you think that this decision is a bit premature? I agree with Adrien that currently all job parameters looks like a table that's easy to watch and use, and 'jumping' to the right side at boolean parameters is, to be honest, not very easy to read (also from the same UX point of view, we get empty gap at the left side where label originally was; i've even created a bug report ( JENKINS-59388 ) and have rewritten several jobs in our organization from 'booleanParam' to 'choice' with 'true'/'false' values before i found this ticket). Probably it would be better to make it configurable or add another type (e.g. BooleanLabel) with UI you propose.
            Hide
            d_garry Igor Rondarev added a comment -

            I've also read JENKINS-56109 story and in common i agree that these 'name'/'value' tables look a bit old-fashioned, and a gap between label and checkbox isn't good too (especially when it's large), but now we've got 'mix' of styles.

            Show
            d_garry Igor Rondarev added a comment - I've also read  JENKINS-56109 story and in common i agree that these 'name'/'value' tables look a bit old-fashioned, and a gap between label and checkbox isn't good too (especially when it's large), but now we've got 'mix' of styles.

              People

              • Assignee:
                jsoref Josh Soref
                Reporter:
                jsoref Josh Soref
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: