Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55787

Switch labels from entry to checkbox

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      This is the preferred style:


      As opposed to:


      or

       

      I'm going to point to this issue for a bunch of plugins.

       

      Note: my initial efforts relied on using optionalBlock instead of entry+checkbox. Unfortunately this interacts poorly w/ the form submission magic, and so rather than continue down that path, I'm switching to moving fields from the entry to the checkbox. The rendering won't generally change from the examples above.

        Attachments

          Activity

          Hide
          kinow Bruno P. Kinoshita added a comment -

          Sorry Josh Soref! I am so used to add the link to the release notes in the Wiki, move to released, and close... then after a few minutes I realized it was not a tap-plugin issue, nor assigned to me.

          I apologize. Re-opened.

          Show
          kinow Bruno P. Kinoshita added a comment - Sorry Josh Soref ! I am so used to add the link to the release notes in the Wiki, move to released, and close... then after a few minutes I realized it was not a tap-plugin issue, nor assigned to me. I apologize. Re-opened.
          Hide
          jsoref Josh Soref added a comment -

          I'm not used to using this JIRA either.

          Since this JIRA allows selecting multiple components, it made sense to use a single ticket for all the instances, so I'm trying to take advantage of that feature.

          Show
          jsoref Josh Soref added a comment - I'm not used to using this JIRA either. Since this JIRA allows selecting multiple components, it made sense to use a single ticket for all the instances, so I'm trying to take advantage of that feature.
          Hide
          alecharp Adrien Lecharpentier added a comment -

          Thank you Josh Soref! I'm speaking about mailer-plugin, as you filled a PR on this plugin. I've attached the screenshots in the PR you opened to see the diff.

          Even if I agree with you that we should have the checkbox before the label, the fact that all Jenkins configurations are structured like a table (with the left column the label and the right column for the field), I fear that changing this might cause some incomprehension.

          Show
          alecharp Adrien Lecharpentier added a comment - Thank you Josh Soref ! I'm speaking about mailer-plugin , as you filled a PR on this plugin. I've attached the screenshots in the PR you opened to see the diff. Even if I agree with you that we should have the checkbox before the label, the fact that all Jenkins configurations are structured like a table  (with the left column the label and the right column for the field), I fear that changing this might cause some incomprehension.
          Hide
          jsoref Josh Soref added a comment -

          Adrien Lecharpentier: once this change is mostly done, JENKINS-56109 / jenkinsci/jenkins#3895 will change the layout away from tables. Note: I'm currently taking a short hiatus from jenkins.

          Show
          jsoref Josh Soref added a comment - Adrien Lecharpentier : once this change is mostly done,  JENKINS-56109  /  jenkinsci/jenkins#3895  will change the layout away from tables. Note: I'm currently taking a short hiatus from jenkins.

            People

            • Assignee:
              jsoref Josh Soref
              Reporter:
              jsoref Josh Soref
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: