Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5600

change pollChanges() to work on revision-id instead of revno

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      At times, depending on what has been done, pollChanges reports no changes erroneously, because removal of revisions and re-pushing to a branch (which happens a log in lp:drizzle/build can cause the same revno to be reported.

      This patch causes the plugin to use revision-id, which is a globally unique id.

        Attachments

          Activity

          Hide
          lifeless lifeless added a comment -

          Looks fine, I'll check it out @ home shortly.

          Show
          lifeless lifeless added a comment - Looks fine, I'll check it out @ home shortly.
          Hide
          lifeless lifeless added a comment -

          Commited to svn, needs a new release done, but I'm hesitant to do that without knowing if there were other outstanding issues/trunk may not be 'baked'. Thanks for the patch.

          Show
          lifeless lifeless added a comment - Commited to svn, needs a new release done, but I'm hesitant to do that without knowing if there were other outstanding issues/trunk may not be 'baked'. Thanks for the patch.
          Hide
          zigarn Alexandre Garnier added a comment - - edited

          With this patch :

          • the revid is always checked on source branch --> in hudson.plugins.bazaar.BazaarSCM.update(AbstractBuild<?, ?>, Launcher, FilePath, BuildListener, File), oldid == newid all the time (or even more : newid can be a new id of source branch) --> the changelog is only on last revision of source branch (or breaks because newid is not in the workspace branch)
          • the revid is badly parsed so that it keeps the '\n' in it and it breaks the log command (split with "\ \s" – without the space – to solve that)
          • the old unused hudson.plugins.bazaar.BazaarSCM.getRevno(Launcher, FilePath, String) is still there...
          Show
          zigarn Alexandre Garnier added a comment - - edited With this patch : the revid is always checked on source branch --> in hudson.plugins.bazaar.BazaarSCM.update(AbstractBuild<?, ?>, Launcher, FilePath, BuildListener, File) , oldid == newid all the time (or even more : newid can be a new id of source branch) --> the changelog is only on last revision of source branch (or breaks because newid is not in the workspace branch) the revid is badly parsed so that it keeps the '\n' in it and it breaks the log command (split with "\ \s" – without the space – to solve that) the old unused hudson.plugins.bazaar.BazaarSCM.getRevno(Launcher, FilePath, String) is still there...
          Hide
          zigarn Alexandre Garnier added a comment -

          Patch to correct this one.

          Show
          zigarn Alexandre Garnier added a comment - Patch to correct this one.
          Hide
          sdirector Monty Taylor added a comment -

          Applied this patch in r27872. Also went ahead and removed getRevno.

          Show
          sdirector Monty Taylor added a comment - Applied this patch in r27872. Also went ahead and removed getRevno.

            People

            • Assignee:
              sdirector Monty Taylor
              Reporter:
              sdirector Monty Taylor
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: