Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-58964

Git not considered modern SCM for git-3.11.0+

    Details

    • Similar Issues:

      Description

      Innocently looking refactoring has caused git not to be considered a modern SCM implementation, until a correction in workflow-cps-global-lib-2.14.

      If newer `git` is used with older `workflow-cps-global-lib`, git is legacy.

        Attachments

          Activity

          Hide
          olivergondza Oliver Gondža added a comment -

          Fix proposed.

          Show
          olivergondza Oliver Gondža added a comment - Fix proposed.
          Hide
          dnusbaum Devin Nusbaum added a comment -

          I think you have the order of operations backwards in your description, see this PR comment for details. Essentially, workflow-cps-global-lib 2.14 preceded git 3.11.0. Because of that, I'm not really sure how we could automatically catch this kind of thing in the future without specifically testing old versions of some plugins with new versions of others in the PCT.

          Show
          dnusbaum Devin Nusbaum added a comment - I think you have the order of operations backwards in your description, see  this PR comment for details . Essentially, workflow-cps-global-lib 2.14 preceded git 3.11.0 . Because of that, I'm not really sure how we could automatically catch this kind of thing in the future without specifically testing old versions of some plugins with new versions of others in the PCT.
          Hide
          oleg_nenashev Oleg Nenashev added a comment -
          Show
          oleg_nenashev Oleg Nenashev added a comment - Devin Nusbaum Hi. Is there a ETA for the https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/78  release?
          Hide
          dnusbaum Devin Nusbaum added a comment -

          Oleg Nenashev No, but I can try to release in the next few weeks. Note though that neither the git nor workflow-cps-global-lib PRs fix the problem, the fix in this case is to only run git 3.11.0 or newer along with workflow-cps-global-lib 2.14 or newer. If you run git 3.11.0 or newer with an older version of workflow-cps-global-lib, that is how you run into the issue.

          Show
          dnusbaum Devin Nusbaum added a comment - Oleg Nenashev No, but I can try to release in the next few weeks. Note though that neither the git nor workflow-cps-global-lib PRs fix the problem, the fix in this case is to only run git 3.11.0 or newer along with workflow-cps-global-lib 2.14 or newer. If you run git 3.11.0 or newer with an older version of workflow-cps-global-lib, that is how you run into the issue.
          Hide
          markewaite Mark Waite added a comment -

          I believe this is resolved by using git plugin 3.12.0 or later. As far as understand from Oliver Gondža, the bug was in the git plugin and the fix is also in the git plugin.

          Show
          markewaite Mark Waite added a comment - I believe this is resolved by using git plugin 3.12.0 or later. As far as understand from Oliver Gondža , the bug was in the git plugin and the fix is also in the git plugin.
          Hide
          dnusbaum Devin Nusbaum added a comment - - edited

          I think that Oliver Gondža thought that workflow-cps-global-lib was a compile scope dependency in git plugin, so that https://github.com/jenkinsci/git-plugin/pull/742 would enforce the dependency requirements for all users, but it is actually test scope, so 3.12.0 should be functionally the same as 3.11.0, and the only fix is to manually make sure you only use those versions of git plugin with workflow-cps-global-lib 2.14 or newer.

          Show
          dnusbaum Devin Nusbaum added a comment - - edited I think that Oliver Gondža thought that workflow-cps-global-lib was a compile scope dependency in git plugin, so that https://github.com/jenkinsci/git-plugin/pull/742 would enforce the dependency requirements for all users, but it is actually test scope , so 3.12.0 should be functionally the same as 3.11.0, and the only fix is to manually make sure you only use those versions of git plugin with workflow-cps-global-lib 2.14 or newer.
          Hide
          markewaite Mark Waite added a comment -

          Thanks for the clarification Devin Nusbaum. I think you're correct based on the comment in that pull request. Fix is to run git plugin 3.12.x with workflow-cps-global-lib 2.14 or newer.

          Show
          markewaite Mark Waite added a comment - Thanks for the clarification Devin Nusbaum . I think you're correct based on the comment in that pull request . Fix is to run git plugin 3.12.x with workflow-cps-global-lib 2.14 or newer.

            People

            • Assignee:
              olivergondza Oliver Gondža
              Reporter:
              olivergondza Oliver Gondža
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: