Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5975

New job starts running before I have a chance to configure the job

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: perforce-plugin
    • Labels:
      None
    • Environment:
      Windows Server 2003
    • Similar Issues:

      Description

      I have an existing job (job1) which is configured to poll SCM every minute.
      Now I create a new job (job2) and I select "copy existing job" and I specify "copy from job1"
      As soon as I hit OK I get the job configuration page.
      Now I start making a few edits to the job configuration page and I notice Hudson just started a build for job2 but I never had a chance to save my edits.

        Attachments

          Issue Links

            Activity

            Hide
            torbent torbent added a comment -

            I totally agree that JENKINS-2494 covers this, and is a "better" (more general) solution. However, it appears that not much is happening on that, so I'll gladly take your fix

            Show
            torbent torbent added a comment - I totally agree that JENKINS-2494 covers this, and is a "better" (more general) solution. However, it appears that not much is happening on that, so I'll gladly take your fix
            Hide
            mdillon mdillon added a comment -

            Looking at the diffs, this appears to make it so that a manual run of the job is required before triggers will take effect. Is that true? If so, that doesn't seem like a real fix to me. We (Yahoo!) happen to have someone looking at JENKINS-2494 again this week; perhaps it would be best to just fix that bug and revert these changes.

            Show
            mdillon mdillon added a comment - Looking at the diffs, this appears to make it so that a manual run of the job is required before triggers will take effect. Is that true? If so, that doesn't seem like a real fix to me. We (Yahoo!) happen to have someone looking at JENKINS-2494 again this week; perhaps it would be best to just fix that bug and revert these changes.
            Hide
            rpetti Rob Petti added a comment -

            Yes, that's exactly what it does (it even says that in the commit log). I'm limited to changing only the perforce plugin code, which can't get any information about whether or not the job has just been copied and not saved yet.

            Perforce requires that a workspace be created on a slave in order to run any perforce commands for polling, so a build must be run anyways if there isn't one. It used to run the job right away, but people with short polling intervals were running into issues when copying jobs, so this was the only way I could 'fix' it.

            I've reopened this bug, so we can revert the changes once you've fixed JENKINS-2494. Thanks!

            Show
            rpetti Rob Petti added a comment - Yes, that's exactly what it does (it even says that in the commit log). I'm limited to changing only the perforce plugin code, which can't get any information about whether or not the job has just been copied and not saved yet. Perforce requires that a workspace be created on a slave in order to run any perforce commands for polling, so a build must be run anyways if there isn't one. It used to run the job right away, but people with short polling intervals were running into issues when copying jobs, so this was the only way I could 'fix' it. I've reopened this bug, so we can revert the changes once you've fixed JENKINS-2494 . Thanks!
            Hide
            mindless Alan Harder added a comment -

            fix for JENKINS-2494 in for 1.361 so you can revert the perforce changes you mentioned pretty soon..

            Show
            mindless Alan Harder added a comment - fix for JENKINS-2494 in for 1.361 so you can revert the perforce changes you mentioned pretty soon..
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : rpetti
            Path:
            trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java
            http://jenkins-ci.org/commit/32023
            Log:
            [FIXED JENKINS-5975] reverting 30325, since this is managed by hudson core now (since 1.361)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : rpetti Path: trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java http://jenkins-ci.org/commit/32023 Log: [FIXED JENKINS-5975] reverting 30325, since this is managed by hudson core now (since 1.361)

              People

              • Assignee:
                rpetti Rob Petti
                Reporter:
                mchartier mchartier
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: