Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5991

Should the default pattern be "**/findbugsXml.xml" instead of "**/findbugs.xml"?

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: findbugs-plugin
    • Labels:
      None
    • Environment:
      Findbugs plugin 4.4 on Hudson 1.351, Windows 2003
    • Similar Issues:

      Description

      We were getting a "Can't copy file from workspace to build folder:" error when trying to view the source from findbugs. Searching online suggested that we change **/findbugs.xml to **/findbugsXml.xml, and that seems to have fixed the issue.

      However, if you leave the configuration box empty, the plugin still defaults to */findbugs.xml. Also, the help files suggest "*/findbugs.xml" is correct. Should this be changed?

      src\main\java\hudson\plugins\findbugs\FindBugsPublisher.java
      private static final String DEFAULT_PATTERN = "**/findbugs.xml";

      src\main\resources\hudson\plugins\findbugs\FindBugsPublisher\config*.properties (all languages)
      src\main\webapp\help*.html (all languages)

        Attachments

          Activity

          Hide
          drulli Ulli Hafner added a comment -

          The default for freestyle projects is findbugs.xml because freestyle projects typically use ant and ant creates a findbugs.xml file. (For m2 projects the correct findbugs file is automatically picked!)

          Maybe I should check in freestyle projects if a maven build step is used. Then the default findbugsXml.xml could be used.

          Please also see JENKINS-5179...

          Show
          drulli Ulli Hafner added a comment - The default for freestyle projects is findbugs.xml because freestyle projects typically use ant and ant creates a findbugs.xml file. (For m2 projects the correct findbugs file is automatically picked!) Maybe I should check in freestyle projects if a maven build step is used. Then the default findbugsXml.xml could be used. Please also see JENKINS-5179 ...
          Hide
          pmv pmv added a comment -

          Thank you very much for the clarification. I wasn't aware there was a difference between ant and maven output files. However, clicking on the help icon makes it painfully obvious that this is already thoroughly documented and the issue lies on this end

          I don't see a need for you to change anything. I will close this issue.

          Show
          pmv pmv added a comment - Thank you very much for the clarification. I wasn't aware there was a difference between ant and maven output files. However, clicking on the help icon makes it painfully obvious that this is already thoroughly documented and the issue lies on this end I don't see a need for you to change anything. I will close this issue.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : drulli
          Path:
          trunk/hudson/plugins/findbugs/plugin/src/main/java/hudson/plugins/findbugs/FindBugsPublisher.java
          trunk/hudson/plugins/findbugs/plugin/src/main/resources/hudson/plugins/findbugs/FindBugsPublisher/config.properties
          trunk/hudson/plugins/findbugs/plugin/src/main/resources/hudson/plugins/findbugs/FindBugsPublisher/config_de.properties
          http://jenkins-ci.org/commit/29252
          Log:
          JENKINS-5991 Use different default filename patterns depending on the project type (ant, maven).

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : drulli Path: trunk/hudson/plugins/findbugs/plugin/src/main/java/hudson/plugins/findbugs/FindBugsPublisher.java trunk/hudson/plugins/findbugs/plugin/src/main/resources/hudson/plugins/findbugs/FindBugsPublisher/config.properties trunk/hudson/plugins/findbugs/plugin/src/main/resources/hudson/plugins/findbugs/FindBugsPublisher/config_de.properties http://jenkins-ci.org/commit/29252 Log: JENKINS-5991 Use different default filename patterns depending on the project type (ant, maven).

            People

            • Assignee:
              drulli Ulli Hafner
              Reporter:
              pmv pmv
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: