Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-60821

Check and update any Jetty code with custom threadpool

    Details

    • Similar Issues:
    • Released As:
      Jenkins 2.218

      Description

      As per Jetty Issue#4492 which was created to report the failure to process requests we have been told that our code is wrong.

      Jesse Glick ​verified the fix in cloudbees-workflow-template-plugin#9 commit 0c4eb98d

      We need to

      • see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔
      • make sure other uses of Jetty in Jenkins are safe
      • winstone ✔
      • maven-hpi-plugin (run mojoe etc) ✔

        Attachments

          Issue Links

            Activity

            Hide
            teilo James Nord added a comment -

            removing the thread naming means the threadpool uses threads starting with "qtp" rather than "Jetty Thread Pool"

            Show
            teilo James Nord added a comment - removing the thread naming means the threadpool uses threads starting with "qtp" rather than "Jetty Thread Pool"
            Hide
            teilo James Nord added a comment -

            maven-hpi-plugin seems unaffected

            winstone allows for configuration of the acceptors and selectors and the max # threads (which by default uses Jetty defaults)

            Show
            teilo James Nord added a comment - maven-hpi-plugin seems unaffected winstone allows for configuration of the acceptors and selectors and the max # threads (which by default uses Jetty defaults )
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            James Nord Winstone fix was shipped in 2.218. Do we need to keep this issue open?

            Show
            oleg_nenashev Oleg Nenashev added a comment - James Nord Winstone fix was shipped in 2.218. Do we need to keep this issue open?
            Hide
            teilo James Nord added a comment -

            Jenkins test harness has not been released yet but happy to close as it's been merged, just not sure on the process for jth

            Show
            teilo James Nord added a comment - Jenkins test harness has not been released yet but happy to close as it's been merged, just not sure on the process for jth
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            I will cut the Jetty release

            Show
            oleg_nenashev Oleg Nenashev added a comment - I will cut the Jetty release
            Hide
            recena Manuel Recena Soto added a comment -

            The links provided in the issue description are broken. I assume they are private links.

            According to the CHANGELOG, we are able to update the status of this issue. It is already released.

            Show
            recena Manuel Recena Soto added a comment - The links provided in the issue description are broken. I assume they are private links. According to the CHANGELOG , we are able to update the status of this issue. It is already released.
            Hide
            teilo James Nord added a comment -

            the link to jetty issue is public. the verification was a private repo

            Show
            teilo James Nord added a comment - the link to jetty issue is public. the verification was a private repo

              People

              • Assignee:
                Unassigned
                Reporter:
                teilo James Nord
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: