Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-61156

Regression: P4 Plugin 1.10.10 trigger doesn't run jobs

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Component/s: p4-plugin
    • Labels:
      None
    • Environment:
      Jenkins LTS 2.204.2 on Windows Server 2016 (64bit)
      Java 1.8.0_144-b01
      p4-plugin 1.10.10
    • Similar Issues:

      Description

      We use a Perforce Trigger that calls curl to POST to the /p4/change endpoint exposed by the p4-plugin. With 1.10.6, this trigger worked, and the relevant job would run.  Upgrading to 1.10.10, and the trigger stopped working.

       

      In investigating the issue, 1.10.10 was still logging "doChange: Received trigger event for: <p4port here>", but the usual followup log "probeJobs: P4: probing: <jenkins job>" never appeared. Rolling the plugin back to 1.10.6 restored the ability to trigger the jenkins job.

        Attachments

          Activity

          Hide
          abutler Adam Butler added a comment -

          Hi Matthew Smeeth apologies if this has caused a regression.  I'm unable to reproduce the issue on our instance of Jenkins (version 2.190.3) and am not in a position to upgrade it at the moment to do further testing due to it being a corporate instance, so it's going to be difficult for me to come up with alternatives at this time.

          I think that your only option is to back this change out for the time being.

          Show
          abutler Adam Butler added a comment - Hi Matthew Smeeth apologies if this has caused a regression.  I'm unable to reproduce the issue on our instance of Jenkins (version 2.190.3) and am not in a position to upgrade it at the moment to do further testing due to it being a corporate instance, so it's going to be difficult for me to come up with alternatives at this time. I think that your only option is to back this change out for the time being.
          Hide
          wbrode William Brode added a comment -

          I and another colleague have installed 1.10.10 and the triggering still seems to be working as expected for us.

          Show
          wbrode William Brode added a comment - I and another colleague have installed 1.10.10 and the triggering still seems to be working as expected for us.
          Hide
          msmeeth Matthew Smeeth added a comment - - edited

          Hi William Brode, can you confirm whether anonymous users have build and read permissions set on your Jenkins server?

          The reason I ask is because I've observed that if you allow anonymous users read and build access(or anything higher) on your Jenkins server, the perforce triggers will still work as expected. Whereas if Jenkins is set up to only allow authenticated users read and build access(or higher), that's when I'm see the issue.

          Show
          msmeeth Matthew Smeeth added a comment - - edited Hi  William Brode , can you confirm whether anonymous users have build and read permissions set on your Jenkins server? The reason I ask is because I've observed that if you allow anonymous users read and build access(or anything higher) on your Jenkins server, the perforce triggers will still work as expected. Whereas if Jenkins is set up to only allow authenticated users read and build access(or higher), that's when I'm see the issue.
          Hide
          wbrode William Brode added a comment -

          Matthew Smeeth Sorry for the delay I missed the notification for this.  We do allow anonymous read but not Build.  Maybe Karl Wirth can verify if anonymous read access is necessary for p4 plugin triggering starting at 1.10.10.  Then again if you updated jenkins core or security plugins around the same time it could be one of them exposing/causing the issue.

          Show
          wbrode William Brode added a comment - Matthew Smeeth Sorry for the delay I missed the notification for this.  We do allow anonymous read but not Build.  Maybe Karl Wirth can verify if anonymous read access is necessary for p4 plugin triggering starting at 1.10.10.  Then again if you updated jenkins core or security plugins around the same time it could be one of them exposing/causing the issue.
          Hide
          msmeeth Matthew Smeeth added a comment -

          Hi William Brode, I'm a bit surprised that it would work without build access, however given that anonymous user has read access on your system, It's possible that's all that's needed to avoid this issue. However once you upgrade to 1.10.11 I think you'll almost certainly hit this issue due to extra security measures we've implemented. 

           

          For now unfortunately I'm going to revert the changes, with a plan to look into implementing this another way in the future.

           

          FYI Adam Butler

          Show
          msmeeth Matthew Smeeth added a comment - Hi William Brode , I'm a bit surprised that it would work without build access, however given that anonymous user has read access on your system, It's possible that's all that's needed to avoid this issue. However once you upgrade to 1.10.11 I think you'll almost certainly hit this issue due to extra security measures we've implemented.    For now unfortunately I'm going to revert the changes, with a plan to look into implementing this another way in the future.   FYI Adam Butler

            People

            • Assignee:
              Unassigned
              Reporter:
              tcramer Tom Cramer
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated: