Details

    • Similar Issues:

      Description

      A checkbox that provides a global Dark Theme configuration.

        Attachments

        1. chrome_Dn1yvh9t3A.png
          chrome_Dn1yvh9t3A.png
          3 kB
        2. dark.png
          dark.png
          41 kB
        3. regex.png
          regex.png
          43 kB

          Activity

          Hide
          fqueiruga Félix Queiruga Balado added a comment -

          I don't know how well would that play on normal UI development. I think it would be a bit of an annoyance to need to always remember the dark mode.

          My ideal solution would be to use CSS variables that a dark theme could override. Example:

          // Jenkins core stylesheet
          :root {
              --body-background: #fefefe;
          }
          
          body {
              background-color: var(--body-background);
          }
          
          
          // On the dark theme stylesheet
          :root {
              --body-background: #000;
          }
          

          I think it's the only way to make it so that the changes will scale. It still has coupling problems, as the CSS variables would then become an API that plugin stylesheets could use. It also needs some deep refactors and changes to happen, but no lesser than having to add a dark comment to all styleshets.

          Show
          fqueiruga Félix Queiruga Balado added a comment - I don't know how well would that play on normal UI development. I think it would be a bit of an annoyance to need to always remember the dark mode. My ideal solution would be to use CSS variables that a dark theme could override. Example: // Jenkins core stylesheet :root { --body- background : #fefefe ; } body { background-color : var(--body- background ); } // On the dark theme stylesheet :root { --body- background : #000 ; } I think it's the only way to make it so that the changes will scale. It still has coupling problems, as the CSS variables would then become an API that plugin stylesheets could use. It also needs some deep refactors and changes to happen, but no lesser than having to add a dark comment to all styleshets.
          Hide
          fqueiruga Félix Queiruga Balado added a comment -

          Gábor Tasnádi The neo2 theme for simple-theme-plugin has a dark mode option: https://github.com/TobiX/jenkins-neo2-theme/tree/master/less Maybe you'll find it interesting.

          Show
          fqueiruga Félix Queiruga Balado added a comment - Gábor Tasnádi The neo2 theme for simple-theme-plugin has a dark mode option: https://github.com/TobiX/jenkins-neo2-theme/tree/master/less Maybe you'll find it interesting.
          Hide
          thinkmassive Alex Miller added a comment -

          Félix Queiruga Balado it looks like the neo2 maintainer removed dark mode the day after you posted that, saying it looked bad and was unmaintainable:
          https://github.com/TobiX/jenkins-neo2-theme/commit/fc74c10f27d66e25c65f436a3ac7ad68dc652caa

          I look forward to the day when jenkins can match the rest of my dashboards in dark mode, will be glad to test prerelease work when it's available.

          Show
          thinkmassive Alex Miller added a comment - Félix Queiruga Balado it looks like the neo2 maintainer removed dark mode the day after you posted that, saying it looked bad and was unmaintainable: https://github.com/TobiX/jenkins-neo2-theme/commit/fc74c10f27d66e25c65f436a3ac7ad68dc652caa I look forward to the day when jenkins can match the rest of my dashboards in dark mode, will be glad to test prerelease work when it's available.
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Another dark theme which is kinda abandoned: https://github.com/camalot/jenkins-dark-stylish 

          After the initial discussions in the UX SIG we agreed to add the Dark theme to the Jenkins UI/UX hackfest project ideas. The event will take place on May 25-29: https://www.jenkins.io/events/online-hackfest/2020-uiux/ 

          Show
          oleg_nenashev Oleg Nenashev added a comment - Another dark theme which is kinda abandoned:  https://github.com/camalot/jenkins-dark-stylish  After the initial discussions in the UX SIG we agreed to add the Dark theme to the Jenkins UI/UX hackfest project ideas. The event will take place on May 25-29:  https://www.jenkins.io/events/online-hackfest/2020-uiux/  
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Gábor Tasnádi are you working on it actively at the moment?

          Show
          oleg_nenashev Oleg Nenashev added a comment - Gábor Tasnádi are you working on it actively at the moment?

            People

            • Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              tasigabi97 Gábor Tasnádi
            • Votes:
              3 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated: