Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6161

Mercurial polling expects 'hg incoming' with 'show newest record first' option enabled

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Duplicate
    • Component/s: mercurial-plugin
    • Labels:
      None
    • Environment:
      Hudson v1.353, Mercurial Plugin v1.28, Mercurial v1.4.1
    • Similar Issues:

      Description

      The default behaviour for 'hg incoming' seems to be 'show newest record last', but parseIncomingOutput method of MercurialSCM class seems to work only with 'show newest record first' option enabled.

      Index: src/main/java/hudson/plugins/mercurial/MercurialSCM.java
      ===================================================================
      --- src/main/java/hudson/plugins/mercurial/MercurialSCM.java	(revision 29721)
      +++ src/main/java/hudson/plugins/mercurial/MercurialSCM.java	(working copy)
      @@ -264,6 +264,7 @@
                   ArgumentListBuilder cmd = findHgExe(node, listener, false);
                   cmd.add(forest ? "fincoming" : "incoming", "--style", tmpFile.getRemote());
                   cmd.add("--no-merges");
      +            cmd.add("--newest-first");
                   cmd.add("--rev", getBranch(env));
                   String cachedSource = cachedSource(node, launcher, listener, true);
                   if (cachedSource != null) {
      

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            It should not matter which order incoming changesets are listed, other than for display in the Changes page. On what basis do you say it "...seems to work only..." with newest changesets first?

            Show
            jglick Jesse Glick added a comment - It should not matter which order incoming changesets are listed, other than for display in the Changes page. On what basis do you say it "...seems to work only..." with newest changesets first?
            Hide
            jglick Jesse Glick added a comment -

            Yes, the symptom was reported separately and I arrived at a similar patch independently.

            Show
            jglick Jesse Glick added a comment - Yes, the symptom was reported separately and I arrived at a similar patch independently.

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                paoloferracin paoloferracin
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: