Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-61700

Windows upload needs required build_version parameter

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: appcenter-plugin
    • Labels:
      None
    • Environment:
      LTS Jenkins & .82 version of appcenter plugin
    • Similar Issues:
    • Released As:
      0.9.2

      Description

      The upload of a zip file to a UWP/Windows App results in a 400 because build_version is not set:

      Creating an upload resource for app.
      Create upload resource for app successful.
      Uploading app to resource.
      io.jenkins.plugins.appcenter.AppCenterException: Upload app to resource unsuccessful: HTTP 400 Bad Request: \{"error":"Error: Missing required params from body: build_version, Service id: 9355f89b-f8f6-42e8-961e-68c4ee11946b"}
       at io.jenkins.plugins.appcenter.AppCenterLogger.logFailure(AppCenterLogger.java:23)
       at io.jenkins.plugins.appcenter.AppCenterLogger.logFailure(AppCenterLogger.java:37)
       at io.jenkins.plugins.appcenter.task.internal.UploadAppToResourceTask.lambda$uploadApp$0(UploadAppToResourceTask.java:71)
       Caused: java.util.concurrent.CompletionException
       at java.util.concurrent.CompletableFuture.encodeRelay(CompletableFuture.java:326)
       at java.util.concurrent.CompletableFuture.completeRelay(CompletableFuture.java:338)
       at java.util.concurrent.CompletableFuture.uniRelay(CompletableFuture.java:911)
       at java.util.concurrent.CompletableFuture$UniRelay.tryFire(CompletableFuture.java:899)
       at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
       at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:1977)
       at io.jenkins.plugins.appcenter.task.internal.UploadAppToResourceTask.lambda$uploadApp$0(UploadAppToResourceTask.java:72)
       at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760)
       at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736)
       at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
       at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:1977)
       at retrofit2.CompletableFutureCallAdapterFactory$BodyCallAdapter$2.onResponse(CompletableFutureCallAdapterFactory.java:81)
       at retrofit2.OkHttpCall$1.onResponse(OkHttpCall.java:129)
       at okhttp3.RealCall$AsyncCall.execute(RealCall.java:174)
       at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
       at java.lang.Thread.run(Thread.java:748)
      

        Attachments

          Activity

          Hide
          svenjost Sven Jost added a comment -
          Show
          svenjost Sven Jost added a comment - The PR is here: https://github.com/jenkinsci/appcenter-plugin/pull/50
          Hide
          mezpahlan Mez Pahlan added a comment -

          Hi Sven Jost big apologies for the delay in replying and thank you for contributing.

          I'm not familiar with the Windows upload requirements in AppCenter but from a quick look at https://docs.microsoft.com/en-us/appcenter/distribution/uploading#windows it appears that there are multiple file formats of which zip is just one - appx, .appxbundle, .appxupload, .msi, .msix, .msixbundle, .msixupload, or .zip.

          That's quite a few formats that I don't understand the implications of as I don't develop for Windows. I think the best thing to do is to limit the scope of this to only support zips for now and gradually add extra support in the future.

          Having said that I'll make some minor changes to your branch and push them but am still in the processes of evaluating the changes so I don't know exactly when these can be released.

          Show
          mezpahlan Mez Pahlan added a comment - Hi Sven Jost big apologies for the delay in replying and thank you for contributing. I'm not familiar with the Windows upload requirements in AppCenter but from a quick look at https://docs.microsoft.com/en-us/appcenter/distribution/uploading#windows it appears that there are multiple file formats of which zip is just one - appx, .appxbundle, .appxupload, .msi, .msix, .msixbundle, .msixupload, or .zip. That's quite a few formats that I don't understand the implications of as I don't develop for Windows. I think the best thing to do is to limit the scope of this to only support zips for now and gradually add extra support in the future. Having said that I'll make some minor changes to your branch and push them but am still in the processes of evaluating the changes so I don't know exactly when these can be released.

            People

            • Assignee:
              mezpahlan Mez Pahlan
              Reporter:
              svenjost Sven Jost
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: