Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7041

Console outline anchors ("Executed Ant Targets") don't work properly

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Environment:
      Hudson 1.367
      Google Chrome 5.0, IE8, and Firefox 3.6
      Windows 7 Enterprise

      Description

      Clicking the console outline anchors doesn't work correctly in any of the browsers I've tried. In IE8, nothing happens. In Chrome and Firefox, it scrolls to the wrong place in the page.

      This is probably because there are duplicate anchors: one in the console output and another in the outline itself. The anchors should be removed from the outline.

      HTML Snippet
      <td id="console-outline-body">
        <li>
          <a href="#ant-target-0">-init</a>
          <a name="ant-target-0"></a><!-- remove this -->
        </li>
        ...
      </td>
      ...
      <pre>
        ...
        <b class="ant-target">
          -init
          <a name="ant-target-0"></a><!-- keep this -->
        </b>
        ...
      </pre>
      

        Activity

        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in hudson
        User: : mindless
        Path:
        trunk/hudson/main/core/src/main/resources/hudson/tasks/_ant/AntTargetNote/script.js
        http://jenkins-ci.org/commit/33171
        Log:
        JENKINS-7041 add anchor after copying e.innerHTML, so anchor isn't added in 2 places.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/main/core/src/main/resources/hudson/tasks/_ant/AntTargetNote/script.js http://jenkins-ci.org/commit/33171 Log: JENKINS-7041 add anchor after copying e.innerHTML, so anchor isn't added in 2 places.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in hudson
        User: : mindless
        Path:
        trunk/hudson/main/core/src/main/resources/hudson/tasks/_ant/AntTargetNote/script.js
        trunk/www/changelog.html
        http://jenkins-ci.org/commit/33176
        Log:
        [FIXED JENKINS-7041] workaround to make ant-target links work in IE8

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/main/core/src/main/resources/hudson/tasks/_ant/AntTargetNote/script.js trunk/www/changelog.html http://jenkins-ci.org/commit/33176 Log: [FIXED JENKINS-7041] workaround to make ant-target links work in IE8
        Hide
        harrygg Harry G. added a comment -

        issue fixed only partially

        This bug still occurs in the running build console.
        It seems to be fixed only for the archived console output.

        If I look in the console of a still running build, I can see ant targets twice in the outline, even if they exist only once.
        Clicking each first one jumps on the second one in the outline instead of to the console.
        Clicking each second one jumps to the first one in the console, even if a second one exists.
        This happens also if the build is finished, but the console was opened before finishing.

        If I open the console of the same build again after finishing, links work fine and the build targets that only exist once also only appear once in the outline.

        Environment: Firefox 3.6, Hudson 1.369 running as a service in Windows XP.

        Show
        harrygg Harry G. added a comment - issue fixed only partially This bug still occurs in the running build console. It seems to be fixed only for the archived console output. If I look in the console of a still running build, I can see ant targets twice in the outline, even if they exist only once. Clicking each first one jumps on the second one in the outline instead of to the console. Clicking each second one jumps to the first one in the console, even if a second one exists. This happens also if the build is finished, but the console was opened before finishing. If I open the console of the same build again after finishing, links work fine and the build targets that only exist once also only appear once in the outline. Environment: Firefox 3.6, Hudson 1.369 running as a service in Windows XP.
        Hide
        mindless Alan Harder added a comment -

        harrygg, please open a new issue for that one, thanks!

        Show
        mindless Alan Harder added a comment - harrygg, please open a new issue for that one, thanks!

          People

          • Assignee:
            mindless Alan Harder
            Reporter:
            malfunction84 Mark Lewis
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: