Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7154

wacky numbering for changes included in a build

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Trivial
    • Resolution: Fixed
    • Component/s: git-plugin
    • Labels:
      None
    • Environment:
      32-bit Ubuntu 10.04 server. Hudson version 1.369. Git plugin version 1.0.
    • Similar Issues:

      Description

      Instead of numbering changes in a build 1,2,3,..., the numbers are strange. For example:

      Changes
      
      #1762 (Aug 6, 2010 10:53:13 AM)
      
      60154. [MIFOS-3328], partially. Added service facade for viewing product categories — Mohammad Shahiduzzaman / gitweb
          7. Addig missing files in previous commit — Mohammad Shahiduzzaman / gitweb
          8. Supressed unknown findbugs warning temporarily to clear build failure — Mohammad Shahiduzzaman / gitweb
          9. [MIFOS-3328], Added service facade for load/create/update product categories — Mohammad Shahiduzzaman / gitweb
          4. productMixDetails controller and static ftl pages without form binding — vishnukmit / gitweb
          6. MIFOS-3329: add copyright to files — Keith Woodlock / gitweb
         35. MIFOS-3320: refactor holiday service facade and dtos and bring in viewHolidays.ftl for link — Keith Woodlock / gitweb
         36. total flow of viewFunds page — vishnukmit / gitweb
       8756. cleaned EditFundsController — vishnukmit / gitweb
       8757. MIFOS-3320: add security and put back in old link for view holidays — Keith Woodlock / gitweb
       8758. fix failing acceptance tests — Keith Woodlock / gitweb
       1001. fix failing acceptance tests (again) — Keith Woodlock / gitweb
      

      http://ci.mifos.org/hudson/job/head-master/changes
      http://yfrog.com/5xscreenshotheadmasterchap

        Attachments

          Issue Links

            Activity

            Hide
            abayer Andrew Bayer added a comment -

            Y'know, I have absolutely no idea how it comes up with those numbers. Lemme check on that.

            Show
            abayer Andrew Bayer added a comment - Y'know, I have absolutely no idea how it comes up with those numbers. Lemme check on that.
            Hide
            abayer Andrew Bayer added a comment -

            Fascinating - the individual build's fine, because that's hudson/model/AbstractBuild/changes.jelly, which loads the ChangeSet implementation's index.jelly - i.e., hudson/plugins/git/GitChangeSetList/index.jelly in this case. Meanwhile, the "recent changes for project" page is hudson/model/AbstractProject/changes.jelly, which loads in hudson/scm/SCM/project-changes.jelly. And that by default is getting that number by change.getRevision(), which is basically gibberish in this context. But it looks like I can override project-changes.jelly in the git plugin - gonna play with that now.

            Show
            abayer Andrew Bayer added a comment - Fascinating - the individual build's fine, because that's hudson/model/AbstractBuild/changes.jelly, which loads the ChangeSet implementation's index.jelly - i.e., hudson/plugins/git/GitChangeSetList/index.jelly in this case. Meanwhile, the "recent changes for project" page is hudson/model/AbstractProject/changes.jelly, which loads in hudson/scm/SCM/project-changes.jelly. And that by default is getting that number by change.getRevision(), which is basically gibberish in this context. But it looks like I can override project-changes.jelly in the git plugin - gonna play with that now.
            Hide
            abayer Andrew Bayer added a comment -

            Fixed! Woo.

            Show
            abayer Andrew Bayer added a comment - Fixed! Woo.
            Hide
            dogfood dogfood added a comment -

            Integrated in plugins_hudson-git-plugin #15
            JENKINS-7154 Added project-changes.jelly so that we don't see revisions used as commit counts in project recent changes

            Andrew Bayer :
            Files :

            • src/main/resources/hudson/plugins/git/GitSCM/project-changes.jelly
            Show
            dogfood dogfood added a comment - Integrated in plugins_hudson-git-plugin #15 JENKINS-7154 Added project-changes.jelly so that we don't see revisions used as commit counts in project recent changes Andrew Bayer : Files : src/main/resources/hudson/plugins/git/GitSCM/project-changes.jelly
            Hide
            meonkeys meonkeys added a comment -

            Just upgraded to 1.0.1. Works for me, thank you!

            I clicked "verify issue", hope that's ok.

            Show
            meonkeys meonkeys added a comment - Just upgraded to 1.0.1. Works for me, thank you! I clicked "verify issue", hope that's ok.

              People

              • Assignee:
                abayer Andrew Bayer
                Reporter:
                meonkeys meonkeys
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: