Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7747

Fisheye: Diff url doesn't work

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Hi there, I'm using perforce plugin 1.1.7. The fisheye diff doesn't work because it uses file revision numbers when it needs to use the changelist revision number. If you leave the r1 value blank then fisheye is smart enough to use the previous revision. For example, here is a fisheye diff that works: https://fisheye.netbase.com/browse/Hudson/depot/branch/maven/src/main/java/Foo.java?r1=&r2=49074

        Attachments

          Activity

          Hide
          rpetti Rob Petti added a comment -

          I'm committing a fix for this shortly, but changes that have already been retrieved will still exhibit the old behavior. Any new changes pulled out of perforce using the plugin should work.

          Show
          rpetti Rob Petti added a comment - I'm committing a fix for this shortly, but changes that have already been retrieved will still exhibit the old behavior. Any new changes pulled out of perforce using the plugin should work.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : rpetti
          Path:
          trunk/hudson/plugins/perforce/src/main/java/com/tek42/perforce/model/Changelist.java
          trunk/hudson/plugins/perforce/src/main/java/com/tek42/perforce/parse/ChangelistBuilder.java
          trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/browsers/FishEyePerforce.java
          http://jenkins-ci.org/commit/35985
          Log:
          [FIXED JENKINS-7747] using the changelist number instead of revision number in FishEye diff links

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : rpetti Path: trunk/hudson/plugins/perforce/src/main/java/com/tek42/perforce/model/Changelist.java trunk/hudson/plugins/perforce/src/main/java/com/tek42/perforce/parse/ChangelistBuilder.java trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/browsers/FishEyePerforce.java http://jenkins-ci.org/commit/35985 Log: [FIXED JENKINS-7747] using the changelist number instead of revision number in FishEye diff links
          Hide
          swolk swolk added a comment -

          Using 1.2.7 and 1.2.8 of the perforce plugin. If I click the diff url in the Changes section, it still uses the revision number which fisheye doesn't like.

          Show
          swolk swolk added a comment - Using 1.2.7 and 1.2.8 of the perforce plugin. If I click the diff url in the Changes section, it still uses the revision number which fisheye doesn't like.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Rob Petti
          Path:
          src/main/java/com/tek42/perforce/model/Changelist.java
          src/main/java/com/tek42/perforce/parse/ChangelistBuilder.java
          src/main/java/hudson/plugins/perforce/PerforceChangeLogSet.java
          src/main/java/hudson/plugins/perforce/browsers/FishEyePerforce.java
          http://jenkins-ci.org/commit/perforce-plugin/a8d7a02b2f99f7ab68e9eef87560baf4d0cc49da
          Log:
          JENKINS-7747 encode the changelist number directly in the changelog.xml for every file so the SCM browsers can retreive it

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rob Petti Path: src/main/java/com/tek42/perforce/model/Changelist.java src/main/java/com/tek42/perforce/parse/ChangelistBuilder.java src/main/java/hudson/plugins/perforce/PerforceChangeLogSet.java src/main/java/hudson/plugins/perforce/browsers/FishEyePerforce.java http://jenkins-ci.org/commit/perforce-plugin/a8d7a02b2f99f7ab68e9eef87560baf4d0cc49da Log: JENKINS-7747 encode the changelist number directly in the changelog.xml for every file so the SCM browsers can retreive it
          Hide
          rpetti Rob Petti added a comment -

          This is fixed by that last commit (a8d7a02b2f99f7ab68e9eef87560baf4d0cc49da). Old changelogs will exhibit the old behavior, but all new ones should work fine now.

          Show
          rpetti Rob Petti added a comment - This is fixed by that last commit (a8d7a02b2f99f7ab68e9eef87560baf4d0cc49da). Old changelogs will exhibit the old behavior, but all new ones should work fine now.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Rob Petti
          Path:
          src/main/java/com/tek42/perforce/model/Changelist.java
          src/main/java/com/tek42/perforce/parse/ChangelistBuilder.java
          src/main/java/hudson/plugins/perforce/PerforceChangeLogSet.java
          src/main/java/hudson/plugins/perforce/browsers/FishEyePerforce.java
          http://jenkins-ci.org/commit/perforce-plugin/a8d7a02b2f99f7ab68e9eef87560baf4d0cc49da
          Log:
          JENKINS-7747 encode the changelist number directly in the changelog.xml for every file so the SCM browsers can retreive it

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rob Petti Path: src/main/java/com/tek42/perforce/model/Changelist.java src/main/java/com/tek42/perforce/parse/ChangelistBuilder.java src/main/java/hudson/plugins/perforce/PerforceChangeLogSet.java src/main/java/hudson/plugins/perforce/browsers/FishEyePerforce.java http://jenkins-ci.org/commit/perforce-plugin/a8d7a02b2f99f7ab68e9eef87560baf4d0cc49da Log: JENKINS-7747 encode the changelist number directly in the changelog.xml for every file so the SCM browsers can retreive it

            People

            • Assignee:
              rpetti Rob Petti
              Reporter:
              swolk swolk
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: