Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-8535

Build should not be marked as failed when tests do not pass

    Details

    • Similar Issues:

      Description

      When a build contains tests that have failed, hudson marks the entire build as failed, which is a bit over the top if we look at the definitions on http://wiki.jenkins-ci.org/display/JENKINS/Terminology

      So I think this is not the right behaviour, the result of the build should be 'unstable'. I can imagine this has something to do with the exit code of the grails command that is run by hudson. Is that what should be fixed? If so I will post an issue in the grails jira.

        Attachments

          Activity

          Show
          alxndrsn Alex Anderson added a comment - (Have posted further thoughts to http://grails.1312388.n4.nabble.com/jenkins-plugin-and-grails-commandline-exit-code-td3773354.html )
          Hide
          alxndrsn Alex Anderson added a comment -

          Now have a Jenkins JIRA ticket to fix the response code: http://jira.grails.org/browse/GRAILS-9481.

          Would be great to get a fix earlier than that though for projects using older versions of grails.

          Show
          alxndrsn Alex Anderson added a comment - Now have a Jenkins JIRA ticket to fix the response code: http://jira.grails.org/browse/GRAILS-9481 . Would be great to get a fix earlier than that though for projects using older versions of grails.
          Hide
          alxndrsn Alex Anderson added a comment -

          Have fixed this and submitted a pull request on Github: https://github.com/jenkinsci/grails-plugin/pull/3

          Show
          alxndrsn Alex Anderson added a comment - Have fixed this and submitted a pull request on Github: https://github.com/jenkinsci/grails-plugin/pull/3
          Hide
          gpinkham Gary Pinkham added a comment -

          @Alex.. forgive me for muddying Jira with the question but seems like the one that gets installed via the plugins interface in jenkins is quite old.. how does one get the version with your changes.. just clone from github and build myself? (I should probably RTFM eh?)

          Show
          gpinkham Gary Pinkham added a comment - @Alex.. forgive me for muddying Jira with the question but seems like the one that gets installed via the plugins interface in jenkins is quite old.. how does one get the version with your changes.. just clone from github and build myself? (I should probably RTFM eh?)
          Hide
          alxndrsn Alex Anderson added a comment -

          IIRC (it's been a few months), `git clone ___ jenkins-grails; cd jenkins-grails; mvn package`.

          This should make an hpi file in ./target/, which you can then install via the Jenkins management GUI.

          Show
          alxndrsn Alex Anderson added a comment - IIRC (it's been a few months), `git clone ___ jenkins-grails; cd jenkins-grails; mvn package`. This should make an hpi file in ./target/, which you can then install via the Jenkins management GUI.

            People

            • Assignee:
              jeffg2one jeffg2one
              Reporter:
              hanswesterbeek hanswesterbeek
            • Votes:
              5 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated: